You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/07/15 09:45:40 UTC
[GitHub] [flink] cshuo opened a new pull request #16503: [FLINK-20323][table/planner] CorrelateSortToRankRule supports dealing…
cshuo opened a new pull request #16503:
URL: https://github.com/apache/flink/pull/16503
… with multiple group keys
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
## Brief change log
Currently, `CorrelateSortToRankRule` cannot deal with multiple group keys, e.g.,
```
def testMultipleGroupingsNotSupported(): Unit = {
val query =
s"""
|SELECT f0, f2
|FROM
| (SELECT DISTINCT f0, f1 FROM t1) t2,
| LATERAL (
| SELECT f2
| FROM t1
| WHERE f0 = t2.f0 AND f1 = t2.f1
| ORDER BY f2
| DESC LIMIT 3
| )
""".stripMargin
util.verifyPlan(query)
}
```
This pr will solve this problem.
## Verifying this change
* Unit test in `CorrelateSortToRankRuleTest`
* IT test in `RankITTest`
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tsreaper commented on pull request #16503: [FLINK-20323][table/planner] CorrelateSortToRankRule supports dealing…
Posted by GitBox <gi...@apache.org>.
tsreaper commented on pull request #16503:
URL: https://github.com/apache/flink/pull/16503#issuecomment-885456168
Also you might want to change your commit user name and email to your github user name and email.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] godfreyhe commented on a change in pull request #16503: [FLINK-20323][table/planner] CorrelateSortToRankRule supports dealing…
Posted by GitBox <gi...@apache.org>.
godfreyhe commented on a change in pull request #16503:
URL: https://github.com/apache/flink/pull/16503#discussion_r675376384
##########
File path: flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/plan/rules/logical/CorrelateSortToRankRuleTest.scala
##########
@@ -95,34 +94,35 @@ class CorrelateSortToRankRuleTest extends TableTestBase {
}
@Test
- def testAggCallNotSupported(): Unit = {
+ def testNonInnerJoinNotSupported(): Unit = {
Review comment:
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] godfreyhe commented on a change in pull request #16503: [FLINK-20323][table/planner] CorrelateSortToRankRule supports dealing…
Posted by GitBox <gi...@apache.org>.
godfreyhe commented on a change in pull request #16503:
URL: https://github.com/apache/flink/pull/16503#discussion_r675378901
##########
File path: flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/plan/rules/logical/CorrelateSortToRankRuleTest.scala
##########
@@ -95,34 +94,35 @@ class CorrelateSortToRankRuleTest extends TableTestBase {
}
@Test
- def testAggCallNotSupported(): Unit = {
+ def testNonInnerJoinNotSupported(): Unit = {
Review comment:
please add some tests about equal with constant value, such as `WHERE f0 = t2.f0 AND f1 = 1` or `WHERE f0 = t2.f0 AND 1 = t2.f1`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16503: [FLINK-20323][table/planner] CorrelateSortToRankRule supports dealing…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16503:
URL: https://github.com/apache/flink/pull/16503#issuecomment-880577837
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a5873dc703589bb70d506587f10023cec027661a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20489",
"triggerID" : "a5873dc703589bb70d506587f10023cec027661a",
"triggerType" : "PUSH"
}, {
"hash" : "a5873dc703589bb70d506587f10023cec027661a",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20537",
"triggerID" : "881145648",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* a5873dc703589bb70d506587f10023cec027661a Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20489) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20537)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16503: [FLINK-20323][table/planner] CorrelateSortToRankRule supports dealing…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16503:
URL: https://github.com/apache/flink/pull/16503#issuecomment-880577837
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a5873dc703589bb70d506587f10023cec027661a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20489",
"triggerID" : "a5873dc703589bb70d506587f10023cec027661a",
"triggerType" : "PUSH"
}, {
"hash" : "a5873dc703589bb70d506587f10023cec027661a",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20537",
"triggerID" : "881145648",
"triggerType" : "MANUAL"
}, {
"hash" : "a5873dc703589bb70d506587f10023cec027661a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20489",
"triggerID" : "881145648",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* a5873dc703589bb70d506587f10023cec027661a Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20537) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20489)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16503: [FLINK-20323][table/planner] CorrelateSortToRankRule supports dealing…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16503:
URL: https://github.com/apache/flink/pull/16503#issuecomment-880577837
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a5873dc703589bb70d506587f10023cec027661a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20489",
"triggerID" : "a5873dc703589bb70d506587f10023cec027661a",
"triggerType" : "PUSH"
}, {
"hash" : "a5873dc703589bb70d506587f10023cec027661a",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20537",
"triggerID" : "881145648",
"triggerType" : "MANUAL"
}, {
"hash" : "a5873dc703589bb70d506587f10023cec027661a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20489",
"triggerID" : "881145648",
"triggerType" : "MANUAL"
}, {
"hash" : "a43d16b1afc27f0f2e3125912ce633b6019bc30b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a43d16b1afc27f0f2e3125912ce633b6019bc30b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a5873dc703589bb70d506587f10023cec027661a Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20537) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20489)
* a43d16b1afc27f0f2e3125912ce633b6019bc30b UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16503: [FLINK-20323][table/planner] CorrelateSortToRankRule supports dealing…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16503:
URL: https://github.com/apache/flink/pull/16503#issuecomment-880556628
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit a43d16b1afc27f0f2e3125912ce633b6019bc30b (Sat Aug 28 12:23:02 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16503: [FLINK-20323][table/planner] CorrelateSortToRankRule supports dealing…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16503:
URL: https://github.com/apache/flink/pull/16503#issuecomment-880577837
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a5873dc703589bb70d506587f10023cec027661a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20489",
"triggerID" : "a5873dc703589bb70d506587f10023cec027661a",
"triggerType" : "PUSH"
}, {
"hash" : "a5873dc703589bb70d506587f10023cec027661a",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20537",
"triggerID" : "881145648",
"triggerType" : "MANUAL"
}, {
"hash" : "a5873dc703589bb70d506587f10023cec027661a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20489",
"triggerID" : "881145648",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* a5873dc703589bb70d506587f10023cec027661a Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20537) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20489)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16503: [FLINK-20323][table/planner] CorrelateSortToRankRule supports dealing…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16503:
URL: https://github.com/apache/flink/pull/16503#issuecomment-880577837
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a5873dc703589bb70d506587f10023cec027661a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20489",
"triggerID" : "a5873dc703589bb70d506587f10023cec027661a",
"triggerType" : "PUSH"
}, {
"hash" : "a5873dc703589bb70d506587f10023cec027661a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20537",
"triggerID" : "881145648",
"triggerType" : "MANUAL"
}, {
"hash" : "a5873dc703589bb70d506587f10023cec027661a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20489",
"triggerID" : "881145648",
"triggerType" : "MANUAL"
}, {
"hash" : "a43d16b1afc27f0f2e3125912ce633b6019bc30b",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20903",
"triggerID" : "a43d16b1afc27f0f2e3125912ce633b6019bc30b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a43d16b1afc27f0f2e3125912ce633b6019bc30b Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20903)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16503: [FLINK-20323][table/planner] CorrelateSortToRankRule supports dealing…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16503:
URL: https://github.com/apache/flink/pull/16503#issuecomment-880577837
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a5873dc703589bb70d506587f10023cec027661a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20489",
"triggerID" : "a5873dc703589bb70d506587f10023cec027661a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a5873dc703589bb70d506587f10023cec027661a Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20489)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] cshuo commented on pull request #16503: [FLINK-20323][table/planner] CorrelateSortToRankRule supports dealing…
Posted by GitBox <gi...@apache.org>.
cshuo commented on pull request #16503:
URL: https://github.com/apache/flink/pull/16503#issuecomment-881116815
@godfreyhe plz have a look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #16503: [FLINK-20323][table/planner] CorrelateSortToRankRule supports dealing…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16503:
URL: https://github.com/apache/flink/pull/16503#issuecomment-880577837
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a5873dc703589bb70d506587f10023cec027661a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a5873dc703589bb70d506587f10023cec027661a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a5873dc703589bb70d506587f10023cec027661a UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] godfreyhe closed pull request #16503: [FLINK-20323][table/planner] CorrelateSortToRankRule supports dealing…
Posted by GitBox <gi...@apache.org>.
godfreyhe closed pull request #16503:
URL: https://github.com/apache/flink/pull/16503
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] godfreyhe commented on a change in pull request #16503: [FLINK-20323][table/planner] CorrelateSortToRankRule supports dealing…
Posted by GitBox <gi...@apache.org>.
godfreyhe commented on a change in pull request #16503:
URL: https://github.com/apache/flink/pull/16503#discussion_r675367436
##########
File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/rules/logical/CorrelateSortToRankRule.scala
##########
@@ -116,7 +121,7 @@ class CorrelateSortToRankRule extends RelOptRule(
if (!variable.id.equals(correlate.getCorrelationId)) {
return false
}
- aggInput.getInput.getDigest.equals(filter.getInput.getDigest)
+ true
Review comment:
nit: simplify these lines to `variable.id.equals(correlate.getCorrelationId)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #16503: [FLINK-20323][table/planner] CorrelateSortToRankRule supports dealing…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16503:
URL: https://github.com/apache/flink/pull/16503#issuecomment-880556628
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit a5873dc703589bb70d506587f10023cec027661a (Thu Jul 15 09:48:03 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-20323).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16503: [FLINK-20323][table/planner] CorrelateSortToRankRule supports dealing…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16503:
URL: https://github.com/apache/flink/pull/16503#issuecomment-880577837
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a5873dc703589bb70d506587f10023cec027661a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20489",
"triggerID" : "a5873dc703589bb70d506587f10023cec027661a",
"triggerType" : "PUSH"
}, {
"hash" : "a5873dc703589bb70d506587f10023cec027661a",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20537",
"triggerID" : "881145648",
"triggerType" : "MANUAL"
}, {
"hash" : "a5873dc703589bb70d506587f10023cec027661a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20489",
"triggerID" : "881145648",
"triggerType" : "MANUAL"
}, {
"hash" : "a43d16b1afc27f0f2e3125912ce633b6019bc30b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20903",
"triggerID" : "a43d16b1afc27f0f2e3125912ce633b6019bc30b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a5873dc703589bb70d506587f10023cec027661a Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20537) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20489)
* a43d16b1afc27f0f2e3125912ce633b6019bc30b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20903)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16503: [FLINK-20323][table/planner] CorrelateSortToRankRule supports dealing…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16503:
URL: https://github.com/apache/flink/pull/16503#issuecomment-880577837
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a5873dc703589bb70d506587f10023cec027661a",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20489",
"triggerID" : "a5873dc703589bb70d506587f10023cec027661a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a5873dc703589bb70d506587f10023cec027661a Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20489)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] cshuo commented on pull request #16503: [FLINK-20323][table/planner] CorrelateSortToRankRule supports dealing…
Posted by GitBox <gi...@apache.org>.
cshuo commented on pull request #16503:
URL: https://github.com/apache/flink/pull/16503#issuecomment-881145648
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tsreaper commented on a change in pull request #16503: [FLINK-20323][table/planner] CorrelateSortToRankRule supports dealing…
Posted by GitBox <gi...@apache.org>.
tsreaper commented on a change in pull request #16503:
URL: https://github.com/apache/flink/pull/16503#discussion_r675354554
##########
File path: flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/plan/rules/logical/CorrelateSortToRankRuleTest.scala
##########
@@ -95,34 +94,35 @@ class CorrelateSortToRankRuleTest extends TableTestBase {
}
@Test
- def testAggCallNotSupported(): Unit = {
+ def testNonInnerJoinNotSupported(): Unit = {
Review comment:
It seems that these tests are just out of order. Reorder the tests and clean up unnecessary changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org