You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "CodePrometheus (via GitHub)" <gi...@apache.org> on 2024/12/26 09:48:32 UTC
[PR] Implement the core functionality of ruby agent tracing [skywalking-ruby]
CodePrometheus opened a new pull request, #1:
URL: https://github.com/apache/skywalking-ruby/pull/1
# Test Report
<img width="800" alt="image" src="https://github.com/user-attachments/assets/6d3a6b72-e738-4fdf-9662-220cbcb55386" />
<img width="800" alt="image" src="https://github.com/user-attachments/assets/b9e78162-bdfa-4498-ae7e-9f87f287ee52" />
For Segment Data side
```
traceId: "842b36d3180241abae4d7329f8d65c71"
traceSegmentId: "d348f0d8d5db4132a66a836340e8bf25"
spans {
spanId: 1
startTime: 1735206158638
endTime: 1735206158641
operationName: "Redis/SET"
peer: "localhost:6379"
spanType: Exit
spanLayer: Cache
componentId: 7
tags {
key: "db.type"
value: "Redis"
}
}
spans {
spanId: 2
startTime: 1735206158641
endTime: 1735206158643
operationName: "Redis/GET"
peer: "localhost:6379"
spanType: Exit
spanLayer: Cache
componentId: 7
tags {
key: "db.type"
value: "Redis"
}
}
spans {
parentSpanId: -1
startTime: 1735206158637
endTime: 1735206158645
operationName: "/hello/sw"
peer: "127.0.0.1:4567"
spanLayer: Http
componentId: 12001
tags {
key: "http.method"
value: "GET"
}
tags {
key: "http.url"
value: "/hello/sw"
}
}
service: "Your_ApplicationName"
serviceInstance: "Your_InstanceName"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Implement the core functionality of ruby agent tracing [skywalking-ruby]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #1:
URL: https://github.com/apache/skywalking-ruby/pull/1#issuecomment-2562749933
Because you made this. https://github.com/apache/skywalking-ruby/blob/main/.asf.yaml#L37
You need a dummy task to make CI check happy, and then you could remove and change the .asf.yaml
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Implement the core functionality of ruby agent tracing [skywalking-ruby]
Posted by "CodePrometheus (via GitHub)" <gi...@apache.org>.
CodePrometheus commented on PR #1:
URL: https://github.com/apache/skywalking-ruby/pull/1#issuecomment-2562715584
The yml I configured does not have `CheckStatus`, and my test [repo](https://github.com/CodePrometheus/skywalking-ruby/pull/3) is not found either. Is there any special configuration for the new repo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Implement the core functionality of ruby agent tracing [skywalking-ruby]
Posted by "CodePrometheus (via GitHub)" <gi...@apache.org>.
CodePrometheus closed pull request #1: Implement the core functionality of ruby agent tracing
URL: https://github.com/apache/skywalking-ruby/pull/1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Implement the core functionality of ruby agent tracing [skywalking-ruby]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #1:
URL: https://github.com/apache/skywalking-ruby/pull/1#issuecomment-2562393290
Cool, have you verified topology and metrics as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Implement the core functionality of ruby agent tracing [skywalking-ruby]
Posted by "CodePrometheus (via GitHub)" <gi...@apache.org>.
CodePrometheus commented on PR #1:
URL: https://github.com/apache/skywalking-ruby/pull/1#issuecomment-2562402177
> Cool, have you verified topology and metrics as well?
It works.
<img width="800" alt="image" src="https://github.com/user-attachments/assets/647c57fe-cf29-45c6-8189-da3b89d8f7c4" />
<img width="800" alt="image" src="https://github.com/user-attachments/assets/2f13510d-ebad-4451-a120-f01d1102620f" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Implement the core functionality of ruby agent tracing [skywalking-ruby]
Posted by "CodePrometheus (via GitHub)" <gi...@apache.org>.
CodePrometheus commented on PR #1:
URL: https://github.com/apache/skywalking-ruby/pull/1#issuecomment-2562788159
Thank you for pointing that out. I overlooked it, it's ok now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Implement the core functionality of ruby agent tracing [skywalking-ruby]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng merged PR #1:
URL: https://github.com/apache/skywalking-ruby/pull/1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org