You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2022/06/02 23:26:37 UTC

[GitHub] [helix] mgao0 commented on a diff in pull request #2137: [WIP]Add backward compatibility support for constructing ZKHelixManager

mgao0 commented on code in PR #2137:
URL: https://github.com/apache/helix/pull/2137#discussion_r888484247


##########
helix-core/src/test/java/org/apache/helix/manager/zk/TestHelixManagerFactory.java:
##########
@@ -0,0 +1,10 @@
+package org.apache.helix.manager.zk;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+public class TestHelixManagerFactory {
+  private static Logger LOG = LoggerFactory.getLogger(TestHelixManagerFactory.class);
+

Review Comment:
   It's still work in progress. I will add the tests once they are completed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org