You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Noemi Pap-Takacs (Code Review)" <ge...@cloudera.org> on 2025/04/22 13:56:50 UTC
[Impala-ASF-CR] IMPALA-13972: TestIcebergRestCatalog.test rest catalog basic should not check erasure coding
Noemi Pap-Takacs has uploaded this change for review. ( http://gerrit.cloudera.org:8080/22801
Change subject: IMPALA-13972: TestIcebergRestCatalog.test_rest_catalog_basic should not check erasure coding
......................................................................
IMPALA-13972: TestIcebergRestCatalog.test_rest_catalog_basic should not check erasure coding
TestIcebergRestCatalog.test_rest_catalog_basic used to check the
erasure coding policy in the table metadata and expected none.
Deleted the check to beable to run the test on any file system
with or without erasure coding.
Change-Id: I8467d420513ab59916351d25c4787c46fb3cef88
---
M testdata/workloads/functional-query/queries/QueryTest/iceberg-rest-catalog.test
1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/01/22801/1
--
To view, visit http://gerrit.cloudera.org:8080/22801
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8467d420513ab59916351d25c4787c46fb3cef88
Gerrit-Change-Number: 22801
Gerrit-PatchSet: 1
Gerrit-Owner: Noemi Pap-Takacs <np...@cloudera.com>
[Impala-ASF-CR] IMPALA-13972: TestIcebergRestCatalog.test rest catalog basic should check erasure coding
Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/22801 )
Change subject: IMPALA-13972: TestIcebergRestCatalog.test_rest_catalog_basic should check erasure coding
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/22801
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8467d420513ab59916351d25c4787c46fb3cef88
Gerrit-Change-Number: 22801
Gerrit-PatchSet: 3
Gerrit-Owner: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 22 Apr 2025 17:41:37 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13972: TestIcebergRestCatalog.test rest catalog basic should check erasure coding
Posted by "Noemi Pap-Takacs (Code Review)" <ge...@cloudera.org>.
Noemi Pap-Takacs has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/22801 )
Change subject: IMPALA-13972: TestIcebergRestCatalog.test_rest_catalog_basic should check erasure coding
......................................................................
IMPALA-13972: TestIcebergRestCatalog.test_rest_catalog_basic should check erasure coding
TestIcebergRestCatalog.test_rest_catalog_basic used to expect
'NONE' as erasure coding policy in the table metadata.
Checking the actual value with regex enables us to run the test
on any file system with or without erasure coding.
Testing:
- executed test_rest_catalog_basic with and without erasure coding
Change-Id: I8467d420513ab59916351d25c4787c46fb3cef88
---
M testdata/workloads/functional-query/queries/QueryTest/iceberg-rest-catalog.test
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/01/22801/3
--
To view, visit http://gerrit.cloudera.org:8080/22801
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8467d420513ab59916351d25c4787c46fb3cef88
Gerrit-Change-Number: 22801
Gerrit-PatchSet: 3
Gerrit-Owner: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-13972: TestIcebergRestCatalog.test rest catalog basic should check erasure coding
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/22801 )
Change subject: IMPALA-13972: TestIcebergRestCatalog.test_rest_catalog_basic should check erasure coding
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/22801
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8467d420513ab59916351d25c4787c46fb3cef88
Gerrit-Change-Number: 22801
Gerrit-PatchSet: 3
Gerrit-Owner: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 22 Apr 2025 20:18:59 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13972: TestIcebergRestCatalog.test rest catalog basic should check erasure coding
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22801 )
Change subject: IMPALA-13972: TestIcebergRestCatalog.test_rest_catalog_basic should check erasure coding
......................................................................
IMPALA-13972: TestIcebergRestCatalog.test_rest_catalog_basic should check erasure coding
TestIcebergRestCatalog.test_rest_catalog_basic used to expect
'NONE' as erasure coding policy in the table metadata.
Checking the actual value with regex enables us to run the test
on any file system with or without erasure coding.
Testing:
- executed test_rest_catalog_basic with and without erasure coding
Change-Id: I8467d420513ab59916351d25c4787c46fb3cef88
Reviewed-on: http://gerrit.cloudera.org:8080/22801
Reviewed-by: Daniel Becker <da...@cloudera.com>
Reviewed-by: Zoltan Borok-Nagy <bo...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M testdata/workloads/functional-query/queries/QueryTest/iceberg-rest-catalog.test
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Daniel Becker: Looks good to me, approved
Zoltan Borok-Nagy: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/22801
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I8467d420513ab59916351d25c4787c46fb3cef88
Gerrit-Change-Number: 22801
Gerrit-PatchSet: 4
Gerrit-Owner: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-13972: TestIcebergRestCatalog.test rest catalog basic should not check erasure coding
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22801 )
Change subject: IMPALA-13972: TestIcebergRestCatalog.test_rest_catalog_basic should not check erasure coding
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/18969/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/22801
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8467d420513ab59916351d25c4787c46fb3cef88
Gerrit-Change-Number: 22801
Gerrit-PatchSet: 1
Gerrit-Owner: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 22 Apr 2025 14:23:41 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13972: TestIcebergRestCatalog.test rest catalog basic should check erasure coding
Posted by "Noemi Pap-Takacs (Code Review)" <ge...@cloudera.org>.
Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/22801 )
Change subject: IMPALA-13972: TestIcebergRestCatalog.test_rest_catalog_basic should check erasure coding
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/22801/1/testdata/workloads/functional-query/queries/QueryTest/iceberg-rest-catalog.test
File testdata/workloads/functional-query/queries/QueryTest/iceberg-rest-catalog.test:
http://gerrit.cloudera.org:8080/#/c/22801/1/testdata/workloads/functional-query/queries/QueryTest/iceberg-rest-catalog.test@a61
PS1, Line 61:
> I think we could also use '$ERASURECODE_POLICY' here, that way we would che
Done
--
To view, visit http://gerrit.cloudera.org:8080/22801
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8467d420513ab59916351d25c4787c46fb3cef88
Gerrit-Change-Number: 22801
Gerrit-PatchSet: 3
Gerrit-Owner: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 22 Apr 2025 17:40:12 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13972: TestIcebergRestCatalog.test rest catalog basic should check erasure coding
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22801 )
Change subject: IMPALA-13972: TestIcebergRestCatalog.test_rest_catalog_basic should check erasure coding
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/22801
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8467d420513ab59916351d25c4787c46fb3cef88
Gerrit-Change-Number: 22801
Gerrit-PatchSet: 3
Gerrit-Owner: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 23 Apr 2025 02:35:10 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13972: TestIcebergRestCatalog.test rest catalog basic should check erasure coding
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22801 )
Change subject: IMPALA-13972: TestIcebergRestCatalog.test_rest_catalog_basic should check erasure coding
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/18975/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/22801
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8467d420513ab59916351d25c4787c46fb3cef88
Gerrit-Change-Number: 22801
Gerrit-PatchSet: 3
Gerrit-Owner: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 22 Apr 2025 18:07:11 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13972: TestIcebergRestCatalog.test rest catalog basic should not check erasure coding
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/22801 )
Change subject: IMPALA-13972: TestIcebergRestCatalog.test_rest_catalog_basic should not check erasure coding
......................................................................
Patch Set 2:
(1 comment)
Thanks for working on this!
http://gerrit.cloudera.org:8080/#/c/22801/1/testdata/workloads/functional-query/queries/QueryTest/iceberg-rest-catalog.test
File testdata/workloads/functional-query/queries/QueryTest/iceberg-rest-catalog.test:
http://gerrit.cloudera.org:8080/#/c/22801/1/testdata/workloads/functional-query/queries/QueryTest/iceberg-rest-catalog.test@a61
PS1, Line 61:
I think we could also use '$ERASURECODE_POLICY' here, that way we would check that the showed value is correct. You might need to turn this to a regex because of the spaces used for padding.
--
To view, visit http://gerrit.cloudera.org:8080/22801
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8467d420513ab59916351d25c4787c46fb3cef88
Gerrit-Change-Number: 22801
Gerrit-PatchSet: 2
Gerrit-Owner: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 22 Apr 2025 14:20:42 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13972: TestIcebergRestCatalog.test rest catalog basic should check erasure coding
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22801 )
Change subject: IMPALA-13972: TestIcebergRestCatalog.test_rest_catalog_basic should check erasure coding
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/11771/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/22801
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8467d420513ab59916351d25c4787c46fb3cef88
Gerrit-Change-Number: 22801
Gerrit-PatchSet: 3
Gerrit-Owner: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 22 Apr 2025 20:19:18 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13972: TestIcebergRestCatalog.test rest catalog basic should not check erasure coding
Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/22801 )
Change subject: IMPALA-13972: TestIcebergRestCatalog.test_rest_catalog_basic should not check erasure coding
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/22801/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/22801/1//COMMIT_MSG@11
PS1, Line 11: beable
Nit: be able
--
To view, visit http://gerrit.cloudera.org:8080/22801
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8467d420513ab59916351d25c4787c46fb3cef88
Gerrit-Change-Number: 22801
Gerrit-PatchSet: 1
Gerrit-Owner: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 22 Apr 2025 14:09:05 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13972: TestIcebergRestCatalog.test rest catalog basic should not check erasure coding
Posted by "Noemi Pap-Takacs (Code Review)" <ge...@cloudera.org>.
Hello Daniel Becker, Zoltan Borok-Nagy, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/22801
to look at the new patch set (#2).
Change subject: IMPALA-13972: TestIcebergRestCatalog.test_rest_catalog_basic should not check erasure coding
......................................................................
IMPALA-13972: TestIcebergRestCatalog.test_rest_catalog_basic should not check erasure coding
TestIcebergRestCatalog.test_rest_catalog_basic used to check the
erasure coding policy in the table metadata and expected none.
Deleted the check to be able to run the test on any file system
with or without erasure coding.
Change-Id: I8467d420513ab59916351d25c4787c46fb3cef88
---
M testdata/workloads/functional-query/queries/QueryTest/iceberg-rest-catalog.test
1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/01/22801/2
--
To view, visit http://gerrit.cloudera.org:8080/22801
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8467d420513ab59916351d25c4787c46fb3cef88
Gerrit-Change-Number: 22801
Gerrit-PatchSet: 2
Gerrit-Owner: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-13972: TestIcebergRestCatalog.test rest catalog basic should not check erasure coding
Posted by "Noemi Pap-Takacs (Code Review)" <ge...@cloudera.org>.
Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/22801 )
Change subject: IMPALA-13972: TestIcebergRestCatalog.test_rest_catalog_basic should not check erasure coding
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/22801/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/22801/1//COMMIT_MSG@11
PS1, Line 11: be abl
> Nit: be able
Done
--
To view, visit http://gerrit.cloudera.org:8080/22801
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8467d420513ab59916351d25c4787c46fb3cef88
Gerrit-Change-Number: 22801
Gerrit-PatchSet: 2
Gerrit-Owner: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 22 Apr 2025 14:14:36 +0000
Gerrit-HasComments: Yes