You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by "okumin (via GitHub)" <gi...@apache.org> on 2025/05/12 11:56:14 UTC

Re: [PR] Fix flaky test in TestLazyBinaryColumnarSerDe by using LinkedHashMap [hive]

okumin commented on code in PR #5791:
URL: https://github.com/apache/hive/pull/5791#discussion_r2084512028


##########
serde/src/test/org/apache/hadoop/hive/serde2/columnar/TestLazyBinaryColumnarSerDe.java:
##########
@@ -165,7 +166,7 @@ public void testLazyBinaryColumnarSerDeWithEmptyBinary() throws SerDeException {
     outerStruct.mByte  = 101;
     outerStruct.mShort = 2002;
     outerStruct.mInt = 3003;
-    outerStruct.mLong = 4004l;
+    outerStruct.mLong = 40041;

Review Comment:
   Probably, the original value is intended. Or we can use an uppercase.
   
   ```suggestion
       outerStruct.mLong = 4004L;
   ```



##########
serde/src/test/org/apache/hadoop/hive/serde2/columnar/TestLazyBinaryColumnarSerDe.java:
##########
@@ -234,7 +235,7 @@ public void testSerDeInnerNulls() throws SerDeException {
     outerStruct.mArray = new ArrayList<InnerStruct>(2);
     outerStruct.mArray.add(is1);
     outerStruct.mArray.add(is2);
-    outerStruct.mMap = new HashMap<String, InnerStruct>();
+    outerStruct.mMap = new LinkedHashMap<String, InnerStruct>(); //fixed line

Review Comment:
   I believe we don't need the additional comment.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org