You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/10/11 05:50:59 UTC

[GitHub] ufoym opened a new pull request #12792: Fix broken amalgamation

ufoym opened a new pull request #12792: Fix broken amalgamation
URL: https://github.com/apache/incubator-mxnet/pull/12792
 
 
   ## Description ##
   Recent updates introduced new functions whose declarations were expanded by the amalgamation script, but left out the definition because the expansion list does not include all necessary header files.
   
   The fix for now is to 
   - deal with ambiguous `complex.h`.
   - include the missing header files in the expansion list.
   
   so that amalgamation can be compiled without errors.
   
   ## Checklist ##
   ### Essentials ###
   Please feel free to remove inapplicable items for your PR.
   - [x] Changes are complete (i.e. I finished coding on this PR)
   - [x] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
   
   ### Changes ###
   - [x] deal with ambiguous `complex.h`.
   - [x] include the missing header files in the expansion list.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services