You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pdfbox.apache.org by michael-dev <gi...@git.apache.org> on 2018/03/29 06:46:38 UTC

[GitHub] pdfbox pull request #45: PDFBOX-4172: do translation when no PDFormXObject i...

GitHub user michael-dev opened a pull request:

    https://github.com/apache/pdfbox/pull/45

    PDFBOX-4172: do translation when no PDFormXObject is encountered

    I've created PDF forms using LibreOffice 5 and for one file, the first
    form element will not show up filled when flattening the PDF.
    
    It turns out that resolveNeedsTranslation does not hit a PDFormXObject
    and thus returns false, although translation is actually needed.
    
    This patch fixes this by tracking whether any PDFormXObject has been
    encountered and returning true when none is seen.
    
    https://issues.apache.org/jira/browse/PDFBOX-4172

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/michael-dev/pdfbox bugfix/flattenCorrectly

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/pdfbox/pull/45.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #45
    
----
commit fed3b1fc607d085f081a5a94bc2deb2dfd73acd4
Author: Michael Braun <mi...@...>
Date:   2018-03-29T06:32:14Z

    PDFBOX-4172: do translation when no PDFormXObject is encountered
    
    I've created PDF forms using LibreOffice 5 and for one file, the first
    form element will not show up filled when flattening the PDF.
    
    It turns out that resolveNeedsTranslation does not hit a PDFormXObject
    and thus returns false, although translation is actually needed.
    
    This patch fixes this by tracking whether any PDFormXObject has been
    encountered and returning true when none is seen.
    
    https://issues.apache.org/jira/browse/PDFBOX-4172

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pdfbox.apache.org
For additional commands, e-mail: dev-help@pdfbox.apache.org


[GitHub] pdfbox pull request #45: PDFBOX-4172: do translation when no PDFormXObject i...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/pdfbox/pull/45


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pdfbox.apache.org
For additional commands, e-mail: dev-help@pdfbox.apache.org