svn commit: r1410817 - in /accumulo/trunk: core/src/main/java/org/apache/accumulo/core/bloomfilter/ core/src/main/java/org/apache/accumulo/core/client/impl/ core/src/main/java/org/apache/accumulo/core/util/ server/src/main/java/org/apache/accumulo/serv...

[me...@apache.org]

Author: medined
Date: Sun Nov 18 02:50:22 2012
New Revision: 1410817

URL: http://svn.apache.org/viewvc?rev=1410817&view=rev
Log:
ACCUMULO-755: Run FindBugs; add final

Modified:
    accumulo/trunk/core/src/main/java/org/apache/accumulo/core/bloomfilter/BloomFilter.java
    accumulo/trunk/core/src/main/java/org/apache/accumulo/core/client/impl/ThriftScanner.java
    accumulo/trunk/core/src/main/java/org/apache/accumulo/core/util/LocalityGroupUtil.java
    accumulo/trunk/core/src/main/java/org/apache/accumulo/core/util/ServerServices.java
    accumulo/trunk/server/src/main/java/org/apache/accumulo/server/metrics/MetricsConfiguration.java
    accumulo/trunk/server/src/main/java/org/apache/accumulo/server/util/TServerUtils.java

Modified: accumulo/trunk/core/src/main/java/org/apache/accumulo/core/bloomfilter/BloomFilter.java
URL: http://svn.apache.org/viewvc/accumulo/trunk/core/src/main/java/org/apache/accumulo/core/bloomfilter/BloomFilter.java?rev=1410817&r1=1410816&r2=1410817&view=diff
==============================================================================
--- accumulo/trunk/core/src/main/java/org/apache/accumulo/core/bloomfilter/BloomFilter.java (original)
+++ accumulo/trunk/core/src/main/java/org/apache/accumulo/core/bloomfilter/BloomFilter.java Sun Nov 18 02:50:22 2012
@@ -217,7 +217,6 @@ public class BloomFilter extends Filter 
       try {
         bits = (BitSet) ois.readObject();
       } catch (ClassNotFoundException e) {
-        // TODO Auto-generated catch block
         e.printStackTrace();
         throw new IOException("BloomFilter tried to deserialize as bitset: " + e);
       }

Modified: accumulo/trunk/core/src/main/java/org/apache/accumulo/core/client/impl/ThriftScanner.java
URL: http://svn.apache.org/viewvc/accumulo/trunk/core/src/main/java/org/apache/accumulo/core/client/impl/ThriftScanner.java?rev=1410817&r1=1410816&r2=1410817&view=diff
==============================================================================
--- accumulo/trunk/core/src/main/java/org/apache/accumulo/core/client/impl/ThriftScanner.java (original)
+++ accumulo/trunk/core/src/main/java/org/apache/accumulo/core/client/impl/ThriftScanner.java Sun Nov 18 02:50:22 2012
@@ -74,7 +74,7 @@ public class ThriftScanner {
   private static final byte[] EMPTY_BYTES = new byte[0];
   private static final Logger log = Logger.getLogger(ThriftScanner.class);
   
-  public static Map<TabletType,Set<String>> serversWaitedForWrites = new EnumMap<TabletType,Set<String>>(TabletType.class);
+  public static final Map<TabletType,Set<String>> serversWaitedForWrites = new EnumMap<TabletType,Set<String>>(TabletType.class);
   
   static {
     for (TabletType ttype : TabletType.values()) {

Modified: accumulo/trunk/core/src/main/java/org/apache/accumulo/core/util/LocalityGroupUtil.java
URL: http://svn.apache.org/viewvc/accumulo/trunk/core/src/main/java/org/apache/accumulo/core/util/LocalityGroupUtil.java?rev=1410817&r1=1410816&r2=1410817&view=diff
==============================================================================
--- accumulo/trunk/core/src/main/java/org/apache/accumulo/core/util/LocalityGroupUtil.java (original)
+++ accumulo/trunk/core/src/main/java/org/apache/accumulo/core/util/LocalityGroupUtil.java Sun Nov 18 02:50:22 2012
@@ -39,7 +39,7 @@ public class LocalityGroupUtil {
   
   // private static final Logger log = Logger.getLogger(ColumnFamilySet.class);
   
-  public static Set<ByteSequence> EMPTY_CF_SET = Collections.emptySet();
+  public static final Set<ByteSequence> EMPTY_CF_SET = Collections.emptySet();
   
   public static Set<ByteSequence> families(Collection<Column> columns) {
     Set<ByteSequence> result = new HashSet<ByteSequence>(columns.size());

Modified: accumulo/trunk/core/src/main/java/org/apache/accumulo/core/util/ServerServices.java
URL: http://svn.apache.org/viewvc/accumulo/trunk/core/src/main/java/org/apache/accumulo/core/util/ServerServices.java?rev=1410817&r1=1410816&r2=1410817&view=diff
==============================================================================
--- accumulo/trunk/core/src/main/java/org/apache/accumulo/core/util/ServerServices.java (original)
+++ accumulo/trunk/core/src/main/java/org/apache/accumulo/core/util/ServerServices.java Sun Nov 18 02:50:22 2012
@@ -41,8 +41,8 @@ public class ServerServices implements C
     }
   }
   
-  public static String SERVICE_SEPARATOR = ";";
-  public static String SEPARATOR_CHAR = "=";
+  public static final String SERVICE_SEPARATOR = ";";
+  public static final String SEPARATOR_CHAR = "=";
   
   private EnumMap<Service,String> services;
   private String stringForm = null;

Modified: accumulo/trunk/server/src/main/java/org/apache/accumulo/server/metrics/MetricsConfiguration.java
URL: http://svn.apache.org/viewvc/accumulo/trunk/server/src/main/java/org/apache/accumulo/server/metrics/MetricsConfiguration.java?rev=1410817&r1=1410816&r2=1410817&view=diff
==============================================================================
--- accumulo/trunk/server/src/main/java/org/apache/accumulo/server/metrics/MetricsConfiguration.java (original)
+++ accumulo/trunk/server/src/main/java/org/apache/accumulo/server/metrics/MetricsConfiguration.java Sun Nov 18 02:50:22 2012
@@ -61,7 +61,7 @@ public class MetricsConfiguration {
   
   private static int CONFIG_FILE_CHECK_COUNTER = 100;
   
-  public static long CONFIG_FILE_RELOAD_DELAY = 60000;
+  public final static long CONFIG_FILE_RELOAD_DELAY = 60000;
   
   private MetricsConfigWatcher watcher = null;
   

Modified: accumulo/trunk/server/src/main/java/org/apache/accumulo/server/util/TServerUtils.java
URL: http://svn.apache.org/viewvc/accumulo/trunk/server/src/main/java/org/apache/accumulo/server/util/TServerUtils.java?rev=1410817&r1=1410816&r2=1410817&view=diff
==============================================================================
--- accumulo/trunk/server/src/main/java/org/apache/accumulo/server/util/TServerUtils.java (original)
+++ accumulo/trunk/server/src/main/java/org/apache/accumulo/server/util/TServerUtils.java Sun Nov 18 02:50:22 2012
@@ -53,7 +53,7 @@ import org.apache.thrift.transport.TTran
 public class TServerUtils {
   private static final Logger log = Logger.getLogger(TServerUtils.class);
   
-  public static ThreadLocal<String> clientAddress = new ThreadLocal<String>();
+  public static final ThreadLocal<String> clientAddress = new ThreadLocal<String>();
   
   public static class ServerPort {
     public final TServer server;