You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2022/04/02 20:58:03 UTC

[GitHub] [geode] pivotal-jbarrett commented on a change in pull request #7548: GEODE-10214: Improve speed of JvmSizeUtils.roundUpSize

pivotal-jbarrett commented on a change in pull request #7548:
URL: https://github.com/apache/geode/pull/7548#discussion_r841118765



##########
File path: geode-core/src/main/java/org/apache/geode/internal/JvmSizeUtils.java
##########
@@ -139,11 +139,7 @@ public static long roundUpSize(long size) {
     // Round up to the nearest 8 bytes. Experimentally, this
     // is what we've seen the sun 32 bit VM do with object size.
     // See https://wiki.gemstone.com/display/rusage/Per+Entry+Overhead

Review comment:
       Can you make these comments javadocs and since this wiki is defunct can you remove the link.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org