You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2021/03/09 20:59:29 UTC

[GitHub] [geode] albertogpz commented on pull request #6096: GEODE-9004: Fix issues with queries targeting a Map field

albertogpz commented on pull request #6096:
URL: https://github.com/apache/geode/pull/6096#issuecomment-794446665


   > Overall, switching from JUnit Assert to AssertJ will provide much better failure messages that will really help anyone dealing with test failures.
   > 
   > `\n` should always be replaced with `System.lineSeparator()`.
   
   Thanks for your comments, Kirk. I thought of changing completely the files I edited to AssertJ but then I realized it would be better just to change to AssertJ my changes and leave the cleaning to another PR so that the core of this PR is not hidden by the other changes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org