[jira] [Commented] (NIFI-5350) Add a way to provide arbitrary Java options in shell scripts

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NIFI-5350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16526796#comment-16526796 ] 

ASF GitHub Bot commented on NIFI-5350:
--------------------------------------

GitHub user lfrancke opened a pull request:

    https://github.com/apache/nifi/pull/2823

    NIFI-5350 Add a way to provide arbitrary Java options in shell scripts

    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [x] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [ ] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/lfrancke/nifi NIFI-5350

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/2823.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2823
    
----
commit a023118111c5a43f0ca93867b03456d41339365f
Author: Lars Francke <la...@...>
Date:   2018-06-28T21:22:49Z

    NIFI-5350 Add a way to provide arbitrary Java options in shell scripts

----


> Add a way to provide arbitrary Java options in shell scripts
> ------------------------------------------------------------
>
>                 Key: NIFI-5350
>                 URL: https://issues.apache.org/jira/browse/NIFI-5350
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Tools and Build
>    Affects Versions: 1.7.0
>            Reporter: Lars Francke
>            Assignee: Lars Francke
>            Priority: Minor
>
> I wanted to change the location of the bootstrap config file which can be done using the System property {{org.apache.nifi.bootstrap.config.file}}. Unfortunately there's no easy way to set that using the default {{nifi.sh}} script.
> It can be done using the {{BOOTSTRAP_DEBUG_PARAMS}} environment variable but that doesn't feel right and can break if anyone actually uses that variable.
> I suggest adding an optional environment variable {{BOOTSTRAP_JAVA_OPTS}} that can be used to pass in extra options to Java



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)