[jira] [Commented] (HADOOP-11088) Unittest TestKeyShell, TestCredShell and TestKMS assume UNIX path separator for JECKS key store path

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-11088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14132074#comment-14132074 ] 

Hadoop QA commented on HADOOP-11088:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12668423/HADOOP-11088.0.patch
  against trunk revision 3122daa.

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 4 new or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-common-project/hadoop-kms:

                  org.apache.hadoop.ipc.TestFairCallQueue
                  org.apache.hadoop.crypto.key.TestValueQueue
                  org.apache.hadoop.ipc.TestDecayRpcScheduler
                  org.apache.hadoop.ipc.TestIPC
                  org.apache.hadoop.crypto.random.TestOsSecureRandom
                  org.apache.hadoop.crypto.key.kms.server.TestKMS

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/4704//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/4704//console

This message is automatically generated.

> Unittest TestKeyShell, TestCredShell and TestKMS assume UNIX path separator for JECKS key store path
> ----------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-11088
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11088
>             Project: Hadoop Common
>          Issue Type: Test
>          Components: security
>    Affects Versions: 2.4.1
>            Reporter: Xiaoyu Yao
>            Assignee: Xiaoyu Yao
>             Fix For: 2.5.1
>
>         Attachments: HADOOP-11088.0.patch
>
>
> TestKeyShell and TestCredShell assume UNIX path separator for JECKS key store path. This will fail the tests on Windows which uses a different path separator. The fix should be something like:
> {code}
> -    jceksProvider = "jceks://file" + tmpDir + "/keystore.jceks";
> +    final Path jksPath = new Path(tmpDir.toString(), "keystore.jceks");
> +    jceksProvider = "jceks://file" + jksPath.toUri();
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)