You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/08/04 11:26:24 UTC
[GitHub] [kafka] nresare opened a new pull request #9122: KAFKA-10314: KafkaStorageException on reassignment when offline log d…
nresare opened a new pull request #9122:
URL: https://github.com/apache/kafka/pull/9122
…irectories exist
Make sure that we set the isNew field in LeaderAndIsrRequest correctly for brokers
that gets added to the replica set on reassignment.
This is tested by creating a variant of ControllerIntergationTest.testPartitionReassignment()
that makes one of the log directories on the target broker offline before initiating the
reassignment. Without the change to the way isNew is set, this fails after a timeout. With
the change, it succeeds.
To facilitate calling causeLogDirFailure() both from ControllerIntegrationTest and
LogDirFailureTest, the method was moved to TestUtils along with the other helper
methods that deals with interacting with KafkaServer instances for test cases.
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.*
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] nresare commented on pull request #9122: KAFKA-10314: KafkaStorageException on reassignment when offline log d…
Posted by GitBox <gi...@apache.org>.
nresare commented on pull request #9122:
URL: https://github.com/apache/kafka/pull/9122#issuecomment-685846761
@mimaison Thanks for having a look! I just rebased and pushed and it seems there are checks being kicked off as well 🎉
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mimaison commented on pull request #9122: KAFKA-10314: KafkaStorageException on reassignment when offline log d…
Posted by GitBox <gi...@apache.org>.
mimaison commented on pull request #9122:
URL: https://github.com/apache/kafka/pull/9122#issuecomment-682006762
Ok to test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mimaison merged pull request #9122: KAFKA-10314: KafkaStorageException on reassignment when offline log d…
Posted by GitBox <gi...@apache.org>.
mimaison merged pull request #9122:
URL: https://github.com/apache/kafka/pull/9122
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mimaison commented on pull request #9122: KAFKA-10314: KafkaStorageException on reassignment when offline log d…
Posted by GitBox <gi...@apache.org>.
mimaison commented on pull request #9122:
URL: https://github.com/apache/kafka/pull/9122#issuecomment-685841902
@nresare Good catch! The change looks good.
Before merging I'd like to get this change tested in the CI pipeline. The Apache Jenkins setup just changed a few days ago and it needs 241e1447fae8b85b3bb491f371357b8f92d2da72 to run. So can you rebase on trunk?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] nresare commented on pull request #9122: KAFKA-10314: KafkaStorageException on reassignment when offline log d…
Posted by GitBox <gi...@apache.org>.
nresare commented on pull request #9122:
URL: https://github.com/apache/kafka/pull/9122#issuecomment-685964373
Trying to navigate the tests, it seems they are related to flakiness in other parts of the overall test suite. Is it possible to re-trigger tests?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org