[GitHub] [apisix] kingluo commented on pull request #9151: feat: Upstream status report

["kingluo (via GitHub)" <gi...@apache.org>]

kingluo commented on PR #9151:
URL: https://github.com/apache/apisix/pull/9151#issuecomment-1487354786

   it's not only for html. it has condition. they did the same things, just for different modules. anyway, naming is subjective, no perfect naming rule for all people. of course, if you insist, i will change it.
   
   
   
   | |
   ***@***.***
   |
   |
   ***@***.***
   |
   
   
   
   
   ---- Replied Message ----
   | From | Liu ***@***.***> |
   | Date | 03/29/2023 01:37 |
   | To | ***@***.***> |
   | Cc | jinhua ***@***.***>***@***.***> |
   | Subject | Re: [apache/apisix] feat: Upstream status report (PR #9151) |
   
   @monkeyDluffy6017 commented on this pull request.
   
   In apisix/control/v1.lua:
   
   >      local infos = {}
        local routes = get_routes()
        iter_and_add_healthcheck_info(infos, routes, "routes")
        local services = get_services()
        iter_and_add_healthcheck_info(infos, services, "services")
        local upstreams = get_upstreams()
        iter_and_add_healthcheck_info(infos, upstreams, "upstreams")
   +    return infos
   +end
   +
   +
   +function _M.get_health_checkers()
   
   
   But the return of the function is not the same, one is an object, the other is an html, the function of the same name is very disturbing
   
   —
   Reply to this email directly, view it on GitHub, or unsubscribe.
   You are receiving this because you authored the thread.Message ID: ***@***.***>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org