You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Julian Foad <ju...@btopenworld.com> on 2008/10/10 09:52:59 UTC
Re: svn commit: r33583 - in trunk/subversion: libsvn_wc
tests/cmdline
On Fri, 2008-10-10 at 01:22 -0700, Greg Stein wrote:
> On Thu, Oct 9, 2008 at 9:45 AM, <ju...@tigris.org> wrote:
> >...
> > +++ trunk/subversion/libsvn_wc/update_editor.c Thu Oct 9 09:45:19 2008 (r33583)
> >...
> > +tree_has_local_mods(svn_boolean_t *modified,
> > + const char *path,
> > + svn_wc_adm_access_t *adm_access,
> > + apr_pool_t *pool)
> > +{
> > +
> > + static svn_wc_entry_callbacks2_t modcheck_callbacks =
> > + { modcheck_found_entry, modcheck_handle_error };
>
> Should be const. (and nit: lose the blank line)
Oh yes. Thanks. r33593.
> > + modcheck_baton_t modcheck_baton = { NULL, FALSE };
> > +
> > + modcheck_baton.adm_access = adm_access;
>
> You can put adm_access into the initializer, rather than use a
> separate statement.
No, you can't use non-constant initializers in C'89. (You can in C'99/C
++/GCC.)
- Julian
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r33583 - in trunk/subversion: libsvn_wc tests/cmdline
Posted by Branko Čibej <br...@xbc.nu>.
Greg Stein wrote:
> On Fri, Oct 10, 2008 at 2:52 AM, Julian Foad <ju...@btopenworld.com> wrote:
>
>> ...
>>
>>>> + modcheck_baton_t modcheck_baton = { NULL, FALSE };
>>>> +
>>>> + modcheck_baton.adm_access = adm_access;
>>>>
>>> You can put adm_access into the initializer, rather than use a
>>> separate statement.
>>>
>> No, you can't use non-constant initializers in C'89. (You can in C'99/C
>> ++/GCC.)
>>
>
> Hmm. Are we trying to work against *that* old of a compiler?
>
Wouldn't be surprised if c99-style non-const initializer breaks on some
still valid version of Microsoft C. AFAIK MS doesn't even try to
modernize its C compiler any more ...
-- Brane
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r33583 - in trunk/subversion: libsvn_wc tests/cmdline
Posted by Greg Stein <gs...@gmail.com>.
On Fri, Oct 10, 2008 at 2:52 AM, Julian Foad <ju...@btopenworld.com> wrote:
>...
>> > + modcheck_baton_t modcheck_baton = { NULL, FALSE };
>> > +
>> > + modcheck_baton.adm_access = adm_access;
>>
>> You can put adm_access into the initializer, rather than use a
>> separate statement.
>
> No, you can't use non-constant initializers in C'89. (You can in C'99/C
> ++/GCC.)
Hmm. Are we trying to work against *that* old of a compiler?
Cheers,
-g
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org