You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2019/12/30 02:00:18 UTC
[GitHub] [incubator-dolphinscheduler] Jave-Chen opened a new pull request
#1633: fix sonarcloud bug
Jave-Chen opened a new pull request #1633: fix sonarcloud bug
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1633
## What is the purpose of the pull request
fix sonarcloud bug
#1632
## Brief change log
1. file: dolphinscheduler-alert/src/main/java/org/apache/dolphinscheduler/alert/utils/EnterpriseWeChatUtils.java
bug:
- https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&issues=AW9PvkP_YzPBRjkobY7y&open=AW9PvkP_YzPBRjkobY7y
- https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&issues=AW9PvkP_YzPBRjkobY7z&open=AW9PvkP_YzPBRjkobY7z
2. file: dolphinscheduler-alert/src/main/java/org/apache/dolphinscheduler/alert/AlertServer.java
bug:
- https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&issues=AW9PvkRwYzPBRjkobY87&open=AW9PvkRwYzPBRjkobY87
## Verify this pull request
This change added tests and can be verified as follows:
re analyzed by sonarcloud, the 3 bugs war fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] qiaozhanwei merged pull request #1633:
fix sonarcloud bug
Posted by GitBox <gi...@apache.org>.
qiaozhanwei merged pull request #1633: fix sonarcloud bug
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1633
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] codecov-io commented on issue #1633:
fix sonarcloud bug
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #1633: fix sonarcloud bug
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1633#issuecomment-569563268
# [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1633?src=pr&el=h1) Report
> Merging [#1633](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1633?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/d3d5726aebdeab98e10abbff725ca7be9be1a911?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1633?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #1633 +/- ##
========================================
- Coverage 8.11% 8.11% -0.01%
========================================
Files 282 282
Lines 13919 13921 +2
Branches 2254 2253 -1
========================================
Hits 1130 1130
- Misses 12671 12673 +2
Partials 118 118
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1633?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...org/apache/dolphinscheduler/alert/AlertServer.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1633/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC9BbGVydFNlcnZlci5qYXZh) | `0% <0%> (ø)` | :arrow_up: |
| [...inscheduler/alert/utils/EnterpriseWeChatUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1633/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC91dGlscy9FbnRlcnByaXNlV2VDaGF0VXRpbHMuamF2YQ==) | `0% <0%> (ø)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1633?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1633?src=pr&el=footer). Last update [d3d5726...2a35409](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1633?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] dailidong commented on issue #1633:
fix sonarcloud bug
Posted by GitBox <gi...@apache.org>.
dailidong commented on issue #1633: fix sonarcloud bug
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1633#issuecomment-569565462
suggestion： maybe the pr title should be relvant to this pr detail info， not sonarcloud bug
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services