You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spark.apache.org by Kay Ousterhout <ke...@eecs.berkeley.edu> on 2014/04/07 19:52:18 UTC
Flaky streaming tests
Hi all,
The InputStreamsSuite seems to have some serious flakiness issues -- I've
seen the file input stream fail many times and now I'm seeing some actor
input stream test failures (
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/13846/consoleFull)
on what I think is an unrelated change. Does anyone know anything about
these? Should we just remove some of these tests since they seem to be
constantly failing?
-Kay
Re: Flaky streaming tests
Posted by Michael Armbrust <mi...@databricks.com>.
I agree these should be disabled right away, and the JIRA can be used to
track fixing / turning them back on.
On Mon, Apr 7, 2014 at 11:33 AM, Michael Armbrust <mi...@databricks.com>wrote:
> There is a JIRA for one of the flakey tests here:
> https://issues.apache.org/jira/browse/SPARK-1409
>
>
> On Mon, Apr 7, 2014 at 11:32 AM, Patrick Wendell <pw...@gmail.com>wrote:
>
>> TD - do you know what is going on here?
>>
>> I looked into this ab it and at least a few of these that use
>> Thread.sleep() and assume the sleep will be exact, which is wrong. We
>> should disable all the tests that do and probably they should be
>> re-written
>> to virtualize time.
>>
>> - Patrick
>>
>>
>> On Mon, Apr 7, 2014 at 10:52 AM, Kay Ousterhout <keo@eecs.berkeley.edu
>> >wrote:
>>
>> > Hi all,
>> >
>> > The InputStreamsSuite seems to have some serious flakiness issues --
>> I've
>> > seen the file input stream fail many times and now I'm seeing some actor
>> > input stream test failures (
>> >
>> >
>> https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/13846/consoleFull
>> > )
>> > on what I think is an unrelated change. Does anyone know anything about
>> > these? Should we just remove some of these tests since they seem to be
>> > constantly failing?
>> >
>> > -Kay
>> >
>>
>
>
Re: Flaky streaming tests
Posted by Michael Armbrust <mi...@databricks.com>.
There is a JIRA for one of the flakey tests here:
https://issues.apache.org/jira/browse/SPARK-1409
On Mon, Apr 7, 2014 at 11:32 AM, Patrick Wendell <pw...@gmail.com> wrote:
> TD - do you know what is going on here?
>
> I looked into this ab it and at least a few of these that use
> Thread.sleep() and assume the sleep will be exact, which is wrong. We
> should disable all the tests that do and probably they should be re-written
> to virtualize time.
>
> - Patrick
>
>
> On Mon, Apr 7, 2014 at 10:52 AM, Kay Ousterhout <keo@eecs.berkeley.edu
> >wrote:
>
> > Hi all,
> >
> > The InputStreamsSuite seems to have some serious flakiness issues -- I've
> > seen the file input stream fail many times and now I'm seeing some actor
> > input stream test failures (
> >
> >
> https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/13846/consoleFull
> > )
> > on what I think is an unrelated change. Does anyone know anything about
> > these? Should we just remove some of these tests since they seem to be
> > constantly failing?
> >
> > -Kay
> >
>
Re: Flaky streaming tests
Posted by Tathagata Das <ta...@gmail.com>.
Yes, I will take a look at those tests ASAP.
TD
On Mon, Apr 7, 2014 at 11:32 AM, Patrick Wendell <pw...@gmail.com> wrote:
> TD - do you know what is going on here?
>
> I looked into this ab it and at least a few of these that use
> Thread.sleep() and assume the sleep will be exact, which is wrong. We
> should disable all the tests that do and probably they should be re-written
> to virtualize time.
>
> - Patrick
>
>
> On Mon, Apr 7, 2014 at 10:52 AM, Kay Ousterhout <keo@eecs.berkeley.edu
> >wrote:
>
> > Hi all,
> >
> > The InputStreamsSuite seems to have some serious flakiness issues -- I've
> > seen the file input stream fail many times and now I'm seeing some actor
> > input stream test failures (
> >
> >
> https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/13846/consoleFull
> > )
> > on what I think is an unrelated change. Does anyone know anything about
> > these? Should we just remove some of these tests since they seem to be
> > constantly failing?
> >
> > -Kay
> >
>
Re: Flaky streaming tests
Posted by Patrick Wendell <pw...@gmail.com>.
TD - do you know what is going on here?
I looked into this ab it and at least a few of these that use
Thread.sleep() and assume the sleep will be exact, which is wrong. We
should disable all the tests that do and probably they should be re-written
to virtualize time.
- Patrick
On Mon, Apr 7, 2014 at 10:52 AM, Kay Ousterhout <ke...@eecs.berkeley.edu>wrote:
> Hi all,
>
> The InputStreamsSuite seems to have some serious flakiness issues -- I've
> seen the file input stream fail many times and now I'm seeing some actor
> input stream test failures (
>
> https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/13846/consoleFull
> )
> on what I think is an unrelated change. Does anyone know anything about
> these? Should we just remove some of these tests since they seem to be
> constantly failing?
>
> -Kay
>
Re: Flaky streaming tests
Posted by Nan Zhu <zh...@gmail.com>.
I met this issue when Jenkins seems to be very busy....
On Monday, April 7, 2014, Kay Ousterhout <ke...@eecs.berkeley.edu> wrote:
> Hi all,
>
> The InputStreamsSuite seems to have some serious flakiness issues -- I've
> seen the file input stream fail many times and now I'm seeing some actor
> input stream test failures (
>
> https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/13846/consoleFull
> )
> on what I think is an unrelated change. Does anyone know anything about
> these? Should we just remove some of these tests since they seem to be
> constantly failing?
>
> -Kay
>