You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2022/02/04 02:21:38 UTC

[GitHub] [trafficserver] ywkaras opened a new pull request #8643: Make sure, when plugins for a GET request to fail, there is always a response body.

ywkaras opened a new pull request #8643:
URL: https://github.com/apache/trafficserver/pull/8643


   Also add classes to CPP API for convenient manipulation of components of HTTP messagess.
   These classes may be used independently of other parts of the TS CPP API.  (This PR is
   absorbing PR #5812.)
   
   Adds Au test with plugin forcing various errors on various hooks, with default body
   or set body.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficserver] ywkaras removed a comment on pull request #8643: Make sure, when plugins cause a GET request to fail, there is always a response body.

Posted by GitBox <gi...@apache.org>.
ywkaras removed a comment on pull request #8643:
URL: https://github.com/apache/trafficserver/pull/8643#issuecomment-1030170802


   [approve ci autest]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficserver] ywkaras edited a comment on pull request #8643: Make sure, when plugins cause a GET request to fail, there is always a response body.

Posted by GitBox <gi...@apache.org>.
ywkaras edited a comment on pull request #8643:
URL: https://github.com/apache/trafficserver/pull/8643#issuecomment-1032110460


   As an alternative to HttpMsgComp.h, Alan proposes https://github.com/SolidWallOfCode/txn_box/blob/master/plugin/include/txn_box/ts_util.h / https://github.com/SolidWallOfCode/txn_box/blob/master/plugin/src/ts_util.cc


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficserver] ywkaras removed a comment on pull request #8643: Make sure, when plugins cause a GET request to fail, there is always a response body.

Posted by GitBox <gi...@apache.org>.
ywkaras removed a comment on pull request #8643:
URL: https://github.com/apache/trafficserver/pull/8643#issuecomment-1030118707


   [approve ci Ubuntu]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficserver] bneradt commented on pull request #8643: Make sure, when plugins cause a GET request to fail, there is always a response body.

Posted by GitBox <gi...@apache.org>.
bneradt commented on pull request #8643:
URL: https://github.com/apache/trafficserver/pull/8643#issuecomment-1035877223


   [approve ci ubuntu]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficserver] ywkaras removed a comment on pull request #8643: Make sure, when plugins cause a GET request to fail, there is always a response body.

Posted by GitBox <gi...@apache.org>.
ywkaras removed a comment on pull request #8643:
URL: https://github.com/apache/trafficserver/pull/8643#issuecomment-1030120061


   [approve ci ubuntu]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficserver] ywkaras commented on pull request #8643: Make sure, when plugins cause a GET request to fail, there is always a response body.

Posted by GitBox <gi...@apache.org>.
ywkaras commented on pull request #8643:
URL: https://github.com/apache/trafficserver/pull/8643#issuecomment-1030118707


   [approve ci Ubuntu]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficserver] ywkaras removed a comment on pull request #8643: Make sure, when plugins cause a GET request to fail, there is always a response body.

Posted by GitBox <gi...@apache.org>.
ywkaras removed a comment on pull request #8643:
URL: https://github.com/apache/trafficserver/pull/8643#issuecomment-1030158377


   [approve ci clang-analyzer]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficserver] ywkaras commented on pull request #8643: Make sure, when plugins cause a GET request to fail, there is always a response body.

Posted by GitBox <gi...@apache.org>.
ywkaras commented on pull request #8643:
URL: https://github.com/apache/trafficserver/pull/8643#issuecomment-1032110460


   As alternative to HttpMsgComp.h, Alan proposes https://github.com/SolidWallOfCode/txn_box/blob/master/plugin/include/txn_box/ts_util.h / https://github.com/SolidWallOfCode/txn_box/blob/master/plugin/src/ts_util.cc


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficserver] ywkaras commented on pull request #8643: Make sure, when plugins cause a GET request to fail, there is always a response body.

Posted by GitBox <gi...@apache.org>.
ywkaras commented on pull request #8643:
URL: https://github.com/apache/trafficserver/pull/8643#issuecomment-1034085424


   [approve ci centos]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficserver] ywkaras commented on pull request #8643: Make sure, when plugins cause a GET request to fail, there is always a response body.

Posted by GitBox <gi...@apache.org>.
ywkaras commented on pull request #8643:
URL: https://github.com/apache/trafficserver/pull/8643#issuecomment-1030170802


   [approve ci autest]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficserver] ywkaras commented on pull request #8643: Make sure, when plugins cause a GET request to fail, there is always a response body.

Posted by GitBox <gi...@apache.org>.
ywkaras commented on pull request #8643:
URL: https://github.com/apache/trafficserver/pull/8643#issuecomment-1030120061


   [approve ci ubuntu]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficserver] ywkaras commented on pull request #8643: Make sure, when plugins cause a GET request to fail, there is always a response body.

Posted by GitBox <gi...@apache.org>.
ywkaras commented on pull request #8643:
URL: https://github.com/apache/trafficserver/pull/8643#issuecomment-1030158377


   [approve ci clang-analyzer]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficserver] ezelkow1 commented on pull request #8643: Make sure, when plugins cause a GET request to fail, there is always a response body.

Posted by GitBox <gi...@apache.org>.
ezelkow1 commented on pull request #8643:
URL: https://github.com/apache/trafficserver/pull/8643#issuecomment-1045221995


   [approve ci rocky]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficserver] bneradt commented on pull request #8643: Make sure, when plugins cause a GET request to fail, there is always a response body.

Posted by GitBox <gi...@apache.org>.
bneradt commented on pull request #8643:
URL: https://github.com/apache/trafficserver/pull/8643#issuecomment-1035877261


   [approve ci autest]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org