You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by tillrohrmann <gi...@git.apache.org> on 2017/03/03 15:10:15 UTC

[GitHub] flink pull request #3415: [FLINK-5916][YARN]make env.java.opts.jobmanager an...

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3415#discussion_r104170895
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/BootstrapTools.java ---
    @@ -360,6 +360,7 @@ public static String getTaskManagerShellCommand(
     							"-Xmx" + tmParams.taskManagerHeapSizeMB() + "m " +
     							"-XX:MaxDirectMemorySize=" + tmParams.taskManagerDirectMemoryLimitMB() + "m");
     		String javaOpts = flinkConfig.getString(CoreOptions.FLINK_JVM_OPTIONS);
    +		javaOpts += " " + flinkConfig.getString(CoreOptions.FLINK_TM_JVM_OPTIONS);
    --- End diff --
    
    Can we only add it if the config string is non-empty?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---