[GitHub] [ozone] adoroszlai commented on a change in pull request #2726: HDDS-5845. Add metrics for stateMachineDataCache cache hit and miss.

[GitBox <gi...@apache.org>]

adoroszlai commented on a change in pull request #2726:
URL: https://github.com/apache/ozone/pull/2726#discussion_r731690066



##########
File path: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/transport/server/ratis/CSMMetrics.java
##########
@@ -59,6 +59,8 @@
   private @Metric MutableCounterLong numReadStateMachineMissCount;
   private @Metric MutableCounterLong numStartTransactionVerifyFailures;
   private @Metric MutableCounterLong numContainerNotOpenVerifyFailures;
+  private @Metric MutableCounterLong numDataCacheMiss;

Review comment:
       Isn't pre-existing `numReadStateMachineMissCount` metric the same as this new one?

##########
File path: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/transport/server/ratis/CSMMetrics.java
##########
@@ -59,6 +59,8 @@
   private @Metric MutableCounterLong numReadStateMachineMissCount;
   private @Metric MutableCounterLong numStartTransactionVerifyFailures;
   private @Metric MutableCounterLong numContainerNotOpenVerifyFailures;
+  private @Metric MutableCounterLong numDataCacheMiss;
+  private @Metric MutableCounterLong numDataCacheHit;

Review comment:
       Could we already calculate this by `numReadStateMachineOps - numReadStateMachineMissCount`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org