You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2018/12/11 16:12:08 UTC
[GitHub] imatiach-msft commented on a change in pull request #17085:
[SPARK-24102][ML][MLLIB] ML Evaluators should use weight column - added
weight column for regression evaluator
imatiach-msft commented on a change in pull request #17085: [SPARK-24102][ML][MLLIB] ML Evaluators should use weight column - added weight column for regression evaluator
URL: https://github.com/apache/spark/pull/17085#discussion_r240677113
##########
File path: mllib/src/main/scala/org/apache/spark/mllib/stat/MultivariateOnlineSummarizer.scala
##########
@@ -52,7 +52,7 @@ class MultivariateOnlineSummarizer extends MultivariateStatisticalSummary with S
private var totalCnt: Long = 0
private var totalWeightSum: Double = 0.0
private var weightSquareSum: Double = 0.0
- private var weightSum: Array[Double] = _
+ private var currWeightSum: Array[Double] = _
Review comment:
done!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org