You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2013/02/02 03:24:00 UTC
Review Request: Resource Monitoring 13: Add executor resource usage to webui.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9269/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Vinod Kone.
Description
-------
Added basic monitoring information into the webui.
Later, we will want to add the ability to see timeseries.
This addresses bug MESOS-99.
https://issues.apache.org/jira/browse/MESOS-99
Diffs
-----
src/webui/master/static/controllers.js f3777083883fce269ec23cbaf145203ecfde158a
src/webui/master/static/slave_executor.html bd06e69b3c99a0a44993c31429d877914b644a1d
src/webui/master/static/slave_framework.html c66150ecb794300239c92ceaf684bfd3f1cb007e
Diff: https://reviews.apache.org/r/9269/diff/
Testing
-------
manual webui testing
Thanks,
Ben Mahler
Re: Review Request: Resource Monitoring 13: Add executor resource usage to
webui.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9269/#review16825
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Hindman
On Feb. 2, 2013, 2:24 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9269/
> -----------------------------------------------------------
>
> (Updated Feb. 2, 2013, 2:24 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> Added basic monitoring information into the webui.
>
> Later, we will want to add the ability to see timeseries.
>
>
> This addresses bug MESOS-99.
> https://issues.apache.org/jira/browse/MESOS-99
>
>
> Diffs
> -----
>
> src/webui/master/static/controllers.js f3777083883fce269ec23cbaf145203ecfde158a
> src/webui/master/static/slave_executor.html bd06e69b3c99a0a44993c31429d877914b644a1d
> src/webui/master/static/slave_framework.html c66150ecb794300239c92ceaf684bfd3f1cb007e
>
> Diff: https://reviews.apache.org/r/9269/diff/
>
>
> Testing
> -------
>
> manual webui testing
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request: Resource Monitoring 13: Add executor resource usage to
webui.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9269/
-----------------------------------------------------------
(Updated Feb. 25, 2013, 7:17 p.m.)
Review request for mesos, Benjamin Hindman and Vinod Kone.
Changes
-------
Rebased off trunk.
Description
-------
Added basic monitoring information into the webui.
Later, we will want to add the ability to see timeseries.
This addresses bug MESOS-99.
https://issues.apache.org/jira/browse/MESOS-99
Diffs (updated)
-----
src/webui/master/static/controllers.js f3777083883fce269ec23cbaf145203ecfde158a
src/webui/master/static/slave_executor.html bd06e69b3c99a0a44993c31429d877914b644a1d
src/webui/master/static/slave_framework.html c66150ecb794300239c92ceaf684bfd3f1cb007e
Diff: https://reviews.apache.org/r/9269/diff/
Testing
-------
manual webui testing
Thanks,
Ben Mahler
Re: Review Request: Resource Monitoring 13: Add executor resource usage to
webui.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9269/
-----------------------------------------------------------
(Updated Feb. 22, 2013, 12:32 a.m.)
Review request for mesos, Benjamin Hindman and Vinod Kone.
Changes
-------
Rebased off trunk.
Description
-------
Added basic monitoring information into the webui.
Later, we will want to add the ability to see timeseries.
This addresses bug MESOS-99.
https://issues.apache.org/jira/browse/MESOS-99
Diffs (updated)
-----
src/webui/master/static/controllers.js f3777083883fce269ec23cbaf145203ecfde158a
src/webui/master/static/slave_executor.html bd06e69b3c99a0a44993c31429d877914b644a1d
src/webui/master/static/slave_framework.html c66150ecb794300239c92ceaf684bfd3f1cb007e
Diff: https://reviews.apache.org/r/9269/diff/
Testing
-------
manual webui testing
Thanks,
Ben Mahler
Re: Review Request: Resource Monitoring 13: Add executor resource usage to
webui.
Posted by Ben Mahler <be...@gmail.com>.
> On Feb. 5, 2013, 10:08 p.m., Vinod Kone wrote:
> > src/webui/master/static/slave_executor.html, line 72
> > <https://reviews.apache.org/r/9269/diff/1/?file=254925#file254925line72>
> >
> > where is this dataSize defined?
Inside app.js, it is a custom filter I created:
<snip>
.filter('dataSize', function() {
return function(bytes) {
if (bytes === null || bytes === undefined || isNaN(bytes)) {
return '';
} else if (bytes < 1024) {
return bytes.toFixed() + ' B';
} else if (bytes < (1024 * 1024)) {
return (bytes / 1024).toFixed() + ' KB';
} else if (bytes < (1024 * 1024 * 1024)) {
return (bytes / (1024 * 1024)).toFixed() + ' MB';
} else {
return (bytes / (1024 * 1024 * 1024)).toFixed() + ' GB';
}
}
})
</snip>
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9269/#review16139
-----------------------------------------------------------
On Feb. 2, 2013, 2:24 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9269/
> -----------------------------------------------------------
>
> (Updated Feb. 2, 2013, 2:24 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> Added basic monitoring information into the webui.
>
> Later, we will want to add the ability to see timeseries.
>
>
> This addresses bug MESOS-99.
> https://issues.apache.org/jira/browse/MESOS-99
>
>
> Diffs
> -----
>
> src/webui/master/static/controllers.js f3777083883fce269ec23cbaf145203ecfde158a
> src/webui/master/static/slave_executor.html bd06e69b3c99a0a44993c31429d877914b644a1d
> src/webui/master/static/slave_framework.html c66150ecb794300239c92ceaf684bfd3f1cb007e
>
> Diff: https://reviews.apache.org/r/9269/diff/
>
>
> Testing
> -------
>
> manual webui testing
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request: Resource Monitoring 13: Add executor resource usage to
webui.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9269/#review16139
-----------------------------------------------------------
Ship it!
src/webui/master/static/slave_executor.html
<https://reviews.apache.org/r/9269/#comment34522>
where is this dataSize defined?
- Vinod Kone
On Feb. 2, 2013, 2:24 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9269/
> -----------------------------------------------------------
>
> (Updated Feb. 2, 2013, 2:24 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> Added basic monitoring information into the webui.
>
> Later, we will want to add the ability to see timeseries.
>
>
> This addresses bug MESOS-99.
> https://issues.apache.org/jira/browse/MESOS-99
>
>
> Diffs
> -----
>
> src/webui/master/static/controllers.js f3777083883fce269ec23cbaf145203ecfde158a
> src/webui/master/static/slave_executor.html bd06e69b3c99a0a44993c31429d877914b644a1d
> src/webui/master/static/slave_framework.html c66150ecb794300239c92ceaf684bfd3f1cb007e
>
> Diff: https://reviews.apache.org/r/9269/diff/
>
>
> Testing
> -------
>
> manual webui testing
>
>
> Thanks,
>
> Ben Mahler
>
>