You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by "Jollyplum (via GitHub)" <gi...@apache.org> on 2026/05/22 23:21:39 UTC
[PR] Mbyrd/cassandra 21199/trunk [cassandra]
Jollyplum opened a new pull request, #4838:
URL: https://github.com/apache/cassandra/pull/4838
for:
https://issues.apache.org/jira/browse/CASSANDRA-21199
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] Mbyrd/cassandra 21199/trunk [cassandra]
Posted by "netudima (via GitHub)" <gi...@apache.org>.
netudima commented on code in PR #4838:
URL: https://github.com/apache/cassandra/pull/4838#discussion_r3302623136
##########
src/java/org/apache/cassandra/cql3/statements/SelectStatement.java:
##########
@@ -369,7 +369,8 @@ public ResultMessage.Rows execute(QueryState state, QueryOptions options, Dispat
checkNotNull(cl, "Invalid empty consistency level");
cl.validateForRead();
- Guardrails.readConsistencyLevels.guard(EnumSet.of(cl), state.getClientState());
+ if Guardrails.readConsistencyLevels.enabled(clientState)
Review Comment:
could you please exclude this change, it is already fixed in [CASSANDRA-21360](https://issues.apache.org/jira/browse/CASSANDRA-21360)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] Mbyrd/cassandra 21199/trunk [cassandra]
Posted by "netudima (via GitHub)" <gi...@apache.org>.
netudima commented on code in PR #4838:
URL: https://github.com/apache/cassandra/pull/4838#discussion_r3302618961
##########
src/java/org/apache/cassandra/utils/MerkleTree.java:
##########
@@ -1482,7 +1482,7 @@ static byte[] xor(byte[] left, byte[] right)
{
assert left.length == right.length;
- byte[] out = Arrays.copyOf(right, right.length);
+ byte[] out = new byte[right.length];
Review Comment:
good catch, it is strange that we have a copy here .. (taking in account the lengths of the arrays are the same)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org