You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by Joe Bowser <bo...@gmail.com> on 2014/01/15 23:32:12 UTC

[Android] LAST CHANCE: Adding Drawables from AOSP to InAppBrowser to conform to OS guidelines

Hey

I'm putting the final touches on the drawables fork, which will add
normal icons to the InAppBrowser so that it looks more like Android
and less like we half-assed it.  I'm sure we'll re-do the UI again in
another re-write, but this looks good.

The source can be found here:
https://github.com/infil00p/cordova-plugin-inappbrowser/tree/drawables

I'll be merging this into the InAppBrowser plugin TOMORROW, so this is
a heads up to actually check this out beforehand.

BTW: This is directly addressing this bug: CB-2495.  The drawables are
customizable.

Re: [Android] LAST CHANCE: Adding Drawables from AOSP to InAppBrowser to conform to OS guidelines

Posted by Marcel Kinard <cm...@gmail.com>.
Nice!

On Jan 16, 2014, at 2:38 PM, Joe Bowser <bo...@gmail.com> wrote:

> This is merged in!  We now have language neutral hawtness.  We'll have
> to revisit this for accessibility, but at least we no longer have
> "Done" hardcoded.


Re: [Android] LAST CHANCE: Adding Drawables from AOSP to InAppBrowser to conform to OS guidelines

Posted by Joe Bowser <bo...@gmail.com>.
This is merged in!  We now have language neutral hawtness.  We'll have
to revisit this for accessibility, but at least we no longer have
"Done" hardcoded.

On Wed, Jan 15, 2014 at 2:32 PM, Joe Bowser <bo...@gmail.com> wrote:
> Hey
>
> I'm putting the final touches on the drawables fork, which will add
> normal icons to the InAppBrowser so that it looks more like Android
> and less like we half-assed it.  I'm sure we'll re-do the UI again in
> another re-write, but this looks good.
>
> The source can be found here:
> https://github.com/infil00p/cordova-plugin-inappbrowser/tree/drawables
>
> I'll be merging this into the InAppBrowser plugin TOMORROW, so this is
> a heads up to actually check this out beforehand.
>
> BTW: This is directly addressing this bug: CB-2495.  The drawables are
> customizable.