You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudberry.apache.org by "lss602726449 (via GitHub)" <gi...@apache.org> on 2026/06/15 09:58:53 UTC

[PR] Fix MERGE16_FIXME: cleanup AO vacuum, PartitionSelector, and qual pushdown [cloudberry]

lss602726449 opened a new pull request, #1820:
URL: https://github.com/apache/cloudberry/pull/1820

   ## Summary
   
   - **Remove unnecessary `vacuum_set_xid_limits` calls for AO/AOCO tables**: AO tables don't have per-tuple transaction IDs, so freeze/cutoff computation is meaningless. Removed the calls from `vacuum_ao.c`, `appendonlyam_handler.c` (CLUSTER), and `aocsam_handler.c` (CLUSTER). Fixed `cluster.c` to properly reset `relminmxid` for AO tables. Deleted the now-unused `vacuum_set_xid_limits` function entirely.
   
   - **Remove incorrect FIXME in PartitionSelector**: The `CreatePartitionPruneState` call is correct for Cloudberry's join-based partition pruning (distinct from `ExecInitPartitionPruning` which adds initial pruning + subplan map renumbering). Also removed two dead declarations (`ExecCreatePartitionPruneState`, `ExecFindInitialMatchingSubPlans`) left over from PG14.
   
   - **Add `UNSAFE_HAS_SUBPLAN` flag for qual pushdown safety**: Replaced the incorrect reuse of `UNSAFE_NOTIN_PARTITIONBY_CLAUSE` (a "soft" unsafe flag that still allows window run conditions) with a proper `UNSAFE_HAS_SUBPLAN` flag (hard block) for output columns containing subplans. This prevents unsafe pushdown of subplan-containing quals into subqueries in Cloudberry's distributed execution model.
   
   ## Test plan
   
   - [x] Compilation passes with `--enable-cassert`
   - [ ] `make installcheck` regression tests pass
   - [ ] `isolation2` tests pass
   - [ ] Verify AO/AOCO VACUUM and CLUSTER operations work correctly
   - [ ] Verify partition pruning with PartitionSelector still works


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org

Re: [PR] Fix MERGE16_FIXME: cleanup AO vacuum, PartitionSelector, and qual pushdown [cloudberry]

Posted by "tuhaihe (via GitHub)" <gi...@apache.org>.
tuhaihe commented on PR #1820:
URL: https://github.com/apache/cloudberry/pull/1820#issuecomment-4796791138

   All tests passed. Let's merge this PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org

Re: [PR] Fix MERGE16_FIXME: cleanup AO vacuum, PartitionSelector, and qual pushdown [cloudberry]

Posted by "tuhaihe (via GitHub)" <gi...@apache.org>.
tuhaihe merged PR #1820:
URL: https://github.com/apache/cloudberry/pull/1820


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org

Re: [PR] Fix MERGE16_FIXME: cleanup AO vacuum, PartitionSelector, and qual pushdown [cloudberry]

Posted by "lss602726449 (via GitHub)" <gi...@apache.org>.
lss602726449 commented on PR #1820:
URL: https://github.com/apache/cloudberry/pull/1820#issuecomment-4785624892

   Fix https://github.com/apache/cloudberry/issues/1790、https://github.com/apache/cloudberry/issues/1789 、https://github.com/apache/cloudberry/issues/1787、https://github.com/apache/cloudberry/issues/1786、https://github.com/apache/cloudberry/issues/1785、https://github.com/apache/cloudberry/issues/1781、https://github.com/apache/cloudberry/issues/1780、https://github.com/apache/cloudberry/issues/1779、https://github.com/apache/cloudberry/issues/1777、https://github.com/apache/cloudberry/issues/1775
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org