You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Anonymous Coward (Code Review)" <ge...@cloudera.org> on 2019/11/02 03:52:43 UTC
[kudu-CR] [fs] gscoped ptr -> unique ptr
lingbinlb@gmail.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14618
Change subject: [fs] gscoped_ptr<T> -> unique_ptr<T>
......................................................................
[fs] gscoped_ptr<T> -> unique_ptr<T>
Replace all existing `gscoped_ptr` in the fs dir with `unique_ptr`.
There are no functional changes here.
Change-Id: I1d7617fd0c51d2a1c7e24e03396bcf8128817cfc
---
M src/kudu/fs/block_manager-stress-test.cc
M src/kudu/fs/block_manager-test.cc
M src/kudu/fs/log_block_manager-test.cc
3 files changed, 7 insertions(+), 10 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/18/14618/1
--
To view, visit http://gerrit.cloudera.org:8080/14618
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1d7617fd0c51d2a1c7e24e03396bcf8128817cfc
Gerrit-Change-Number: 14618
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <li...@gmail.com>
[kudu-CR] [fs] gscoped ptr -> unique ptr
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14618 )
Change subject: [fs] gscoped_ptr<T> -> unique_ptr<T>
......................................................................
[fs] gscoped_ptr<T> -> unique_ptr<T>
Replace all existing `gscoped_ptr` in the fs dir with `unique_ptr`.
There are no functional changes here.
Change-Id: I1d7617fd0c51d2a1c7e24e03396bcf8128817cfc
Reviewed-on: http://gerrit.cloudera.org:8080/14618
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M src/kudu/fs/block_manager-stress-test.cc
M src/kudu/fs/block_manager-test.cc
M src/kudu/fs/log_block_manager-test.cc
3 files changed, 7 insertions(+), 10 deletions(-)
Approvals:
Kudu Jenkins: Verified
Adar Dembo: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/14618
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I1d7617fd0c51d2a1c7e24e03396bcf8128817cfc
Gerrit-Change-Number: 14618
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <li...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [fs] gscoped ptr -> unique ptr
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14618 )
Change subject: [fs] gscoped_ptr<T> -> unique_ptr<T>
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14618
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1d7617fd0c51d2a1c7e24e03396bcf8128817cfc
Gerrit-Change-Number: 14618
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <li...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 02 Nov 2019 05:21:45 +0000
Gerrit-HasComments: No