You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kyuubi.apache.org by bo...@apache.org on 2023/05/18 00:54:51 UTC

[kyuubi] branch master updated: [KYUUBI #4850] Change default EC spec to secp521r1 for internal session variable signature

This is an automated email from the ASF dual-hosted git repository.

bowenliang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/kyuubi.git


The following commit(s) were added to refs/heads/master by this push:
     new dbcbeecb1 [KYUUBI #4850] Change default EC spec to secp521r1 for internal session variable signature
dbcbeecb1 is described below

commit dbcbeecb16d04c6ef704152a79546aba882a1a15
Author: liangbowen <li...@gf.com.cn>
AuthorDate: Thu May 18 08:54:39 2023 +0800

    [KYUUBI #4850] Change default EC spec to secp521r1 for internal session variable signature
    
    ### _Why are the changes needed?_
    
    - change the default EC spec from secp256k1 to secp521r1, as secp256k1 not supported on Java 17
    
    ### _How was this patch tested?_
    - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
    
    - [ ] Add screenshots for manual tests if appropriate
    
    - [x] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request
    
    Closes #4850 from bowenliang123/secp384r1.
    
    Closes #4850
    
    73e0dad30 [liangbowen] change EC spec to secp521r1
    5b9528ede [liangbowen] change EC spec to secp384r1
    
    Authored-by: liangbowen <li...@gf.com.cn>
    Signed-off-by: liangbowen <li...@gf.com.cn>
---
 kyuubi-common/src/main/scala/org/apache/kyuubi/util/SignUtils.scala | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kyuubi-common/src/main/scala/org/apache/kyuubi/util/SignUtils.scala b/kyuubi-common/src/main/scala/org/apache/kyuubi/util/SignUtils.scala
index 6f7ff18df..7fb4fde2e 100644
--- a/kyuubi-common/src/main/scala/org/apache/kyuubi/util/SignUtils.scala
+++ b/kyuubi-common/src/main/scala/org/apache/kyuubi/util/SignUtils.scala
@@ -27,7 +27,7 @@ object SignUtils {
 
   private lazy val ecKeyPairGenerator = {
     val g = KeyPairGenerator.getInstance(KEYPAIR_ALGORITHM_EC)
-    g.initialize(new ECGenParameterSpec("secp256k1"), new SecureRandom())
+    g.initialize(new ECGenParameterSpec("secp521r1"), new SecureRandom())
     g
   }