You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2019/12/02 03:24:38 UTC

[GitHub] [hbase] anoopsjohn commented on a change in pull request #868: HBASE-23296 Add CompositeBucketCache to support tiered BC

anoopsjohn commented on a change in pull request #868: HBASE-23296 Add CompositeBucketCache to support tiered BC
URL: https://github.com/apache/hbase/pull/868#discussion_r352201788
 
 

 ##########
 File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/BlockCache.java
 ##########
 @@ -28,6 +28,10 @@
  */
 @InterfaceAudience.Private
 public interface BlockCache extends Iterable<CachedBlock> {
+  public enum CacheLevel {
+    L1, L2
 
 Review comment:
   When we have on heap cache and a BucketCache, or 2 Bucket Cache are we making it like L1 and L2 really now?  That the caching of all blocks starts with L1 and L2 is victim handler for the eviction? I think no. If so better to avoid the term L1 and L2 IMHO.  We have done that as part of some work and removed this. Not getting other naming also. Suggestions?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services