You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "amaliujia (via GitHub)" <gi...@apache.org> on 2023/07/20 08:41:15 UTC
[GitHub] [spark] amaliujia opened a new pull request, #42092: [SPARK-44496][SQL][CONNECT] Move Interfaces needed by SCSC to sql/api
amaliujia opened a new pull request, #42092:
URL: https://github.com/apache/spark/pull/42092
[<!--](url)
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This PR moves some interfaces and utils that are needed by scala client to sql/api.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
So that scala client does not need to depend on Spark.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
UT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] hvanhovell commented on a diff in pull request #42092: [SPARK-44496][SQL][CONNECT] Move Interfaces needed by SCSC to sql/api
Posted by "hvanhovell (via GitHub)" <gi...@apache.org>.
hvanhovell commented on code in PR #42092:
URL: https://github.com/apache/spark/pull/42092#discussion_r1269224623
##########
connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/Dataset.scala:
##########
@@ -876,7 +876,7 @@ class Dataset[T] private[sql] (
val tupleEncoder =
ProductEncoder[(T, U)](
- ClassTag(Utils.getContextOrSparkClassLoader.loadClass(s"scala.Tuple2")),
+ ClassTag(SparkClassUtils.getContextOrSparkClassLoader.loadClass(s"scala.Tuple2")),
Review Comment:
@zhenlineo we should move this code to AgnosticEncoder.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a diff in pull request #42092: [SPARK-44496][SQL][CONNECT] Move Interfaces needed by SCSC to sql/api
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #42092:
URL: https://github.com/apache/spark/pull/42092#discussion_r1325276129
##########
project/MimaExcludes.scala:
##########
@@ -174,6 +174,35 @@ object MimaExcludes {
ProblemFilters.exclude[MissingClassProblem]("org.apache.spark.sql.types.ObjectType"),
ProblemFilters.exclude[MissingClassProblem]("org.apache.spark.sql.types.ObjectType$"),
+ // SPARK-44496: Move Interfaces needed by SCSC to sql/api.
+ ProblemFilters.exclude[MissingClassProblem]("org.apache.spark.sql.Encoder"),
Review Comment:
If this is the case, they should be put into `v35excludes` for future unified cleanup, rather than being placed into `defaultExcludes`. The items placed into `defaultExcludes` generally represent the rules that will never participate in the mima check. I've submitted a PR to move the similar cases to v35excludes : https://github.com/apache/spark/pull/42912
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] hvanhovell commented on pull request #42092: [SPARK-44496][SQL][CONNECT] Move Interfaces needed by SCSC to sql/api
Posted by "hvanhovell (via GitHub)" <gi...@apache.org>.
hvanhovell commented on PR #42092:
URL: https://github.com/apache/spark/pull/42092#issuecomment-1646693433
Merging!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] bogao007 commented on pull request #42092: [SPARK-44496][SQL][CONNECT] Move Interfaces needed by SCSC to sql/api
Posted by "bogao007 (via GitHub)" <gi...@apache.org>.
bogao007 commented on PR #42092:
URL: https://github.com/apache/spark/pull/42092#issuecomment-1644286363
> LGTM cc @bogao007 We need to do the same for Streaming. I recall you put a few in `connect-common`, we shall move them out too.
Sure, will do the same, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] hvanhovell closed pull request #42092: [SPARK-44496][SQL][CONNECT] Move Interfaces needed by SCSC to sql/api
Posted by "hvanhovell (via GitHub)" <gi...@apache.org>.
hvanhovell closed pull request #42092: [SPARK-44496][SQL][CONNECT] Move Interfaces needed by SCSC to sql/api
URL: https://github.com/apache/spark/pull/42092
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on a diff in pull request #42092: [SPARK-44496][SQL][CONNECT] Move Interfaces needed by SCSC to sql/api
Posted by "amaliujia (via GitHub)" <gi...@apache.org>.
amaliujia commented on code in PR #42092:
URL: https://github.com/apache/spark/pull/42092#discussion_r1325124633
##########
project/MimaExcludes.scala:
##########
@@ -174,6 +174,35 @@ object MimaExcludes {
ProblemFilters.exclude[MissingClassProblem]("org.apache.spark.sql.types.ObjectType"),
ProblemFilters.exclude[MissingClassProblem]("org.apache.spark.sql.types.ObjectType$"),
+ // SPARK-44496: Move Interfaces needed by SCSC to sql/api.
+ ProblemFilters.exclude[MissingClassProblem]("org.apache.spark.sql.Encoder"),
Review Comment:
@LuciferYang
The intention here is to exclude these from spark 3.4 Mima check and I expected once we release Spark 3.5, these will be deleted (as we relocate those classes in 3.4 but in 3.5 they becomes existing behavior).
WIth this context where you think we'd better put these rules?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a diff in pull request #42092: [SPARK-44496][SQL][CONNECT] Move Interfaces needed by SCSC to sql/api
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #42092:
URL: https://github.com/apache/spark/pull/42092#discussion_r1324738993
##########
project/MimaExcludes.scala:
##########
@@ -174,6 +174,35 @@ object MimaExcludes {
ProblemFilters.exclude[MissingClassProblem]("org.apache.spark.sql.types.ObjectType"),
ProblemFilters.exclude[MissingClassProblem]("org.apache.spark.sql.types.ObjectType$"),
+ // SPARK-44496: Move Interfaces needed by SCSC to sql/api.
+ ProblemFilters.exclude[MissingClassProblem]("org.apache.spark.sql.Encoder"),
Review Comment:
@amaliujia Apologies for the late comment. Why were these `ProblemFilters` placed in `defaultExcludes` instead of `v35excludes`? Will they never be involved in the Mima check again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on a diff in pull request #42092: [SPARK-44496][SQL][CONNECT] Move Interfaces needed by SCSC to sql/api
Posted by "amaliujia (via GitHub)" <gi...@apache.org>.
amaliujia commented on code in PR #42092:
URL: https://github.com/apache/spark/pull/42092#discussion_r1325124633
##########
project/MimaExcludes.scala:
##########
@@ -174,6 +174,35 @@ object MimaExcludes {
ProblemFilters.exclude[MissingClassProblem]("org.apache.spark.sql.types.ObjectType"),
ProblemFilters.exclude[MissingClassProblem]("org.apache.spark.sql.types.ObjectType$"),
+ // SPARK-44496: Move Interfaces needed by SCSC to sql/api.
+ ProblemFilters.exclude[MissingClassProblem]("org.apache.spark.sql.Encoder"),
Review Comment:
@LuciferYang
The intention here is to exclude these from spark 3.4 Mima check and I expected once we release Spark 3.5, these will be deleted?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a diff in pull request #42092: [SPARK-44496][SQL][CONNECT] Move Interfaces needed by SCSC to sql/api
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #42092:
URL: https://github.com/apache/spark/pull/42092#discussion_r1325276129
##########
project/MimaExcludes.scala:
##########
@@ -174,6 +174,35 @@ object MimaExcludes {
ProblemFilters.exclude[MissingClassProblem]("org.apache.spark.sql.types.ObjectType"),
ProblemFilters.exclude[MissingClassProblem]("org.apache.spark.sql.types.ObjectType$"),
+ // SPARK-44496: Move Interfaces needed by SCSC to sql/api.
+ ProblemFilters.exclude[MissingClassProblem]("org.apache.spark.sql.Encoder"),
Review Comment:
If this is the case, they should be put into `v35excludes` for future unified cleanup, rather than being placed into `defaultExcludes`. The items placed into `defaultExcludes` generally represent the rules that will never participate in the mima check. ~I've submitted a PR to move the similar cases to v35excludes : https://github.com/apache/spark/pull/42912~
delete them in https://github.com/apache/spark/pull/42921, please help to check if you have time. thanks
##########
project/MimaExcludes.scala:
##########
@@ -174,6 +174,35 @@ object MimaExcludes {
ProblemFilters.exclude[MissingClassProblem]("org.apache.spark.sql.types.ObjectType"),
ProblemFilters.exclude[MissingClassProblem]("org.apache.spark.sql.types.ObjectType$"),
+ // SPARK-44496: Move Interfaces needed by SCSC to sql/api.
+ ProblemFilters.exclude[MissingClassProblem]("org.apache.spark.sql.Encoder"),
Review Comment:
If this is the case, they should be put into `v35excludes` for future unified cleanup, rather than being placed into `defaultExcludes`. The items placed into `defaultExcludes` generally represent the rules that will never participate in the mima check. ~I've submitted a PR to move the similar cases to v35excludes : https://github.com/apache/spark/pull/42912~
Delete them in https://github.com/apache/spark/pull/42921, please help to check if you have time. thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org