You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by "sz-p (via GitHub)" <gi...@apache.org> on 2024/11/26 12:25:06 UTC
[PR] fix(log): barMinHeight not work with startvalue greater than 10 [echarts]
sz-p opened a new pull request, #20541:
URL: https://github.com/apache/echarts/pull/20541
<!-- Please fill in the following information to help us review your PR more efficiently. -->
## Brief Information
This pull request is in the type of:
- [x] bug fixing
- [ ] new feature
- [ ] others
### What does this PR do?
<!-- USE ONE SENTENCE TO DESCRIBE WHAT THIS PR DOES. -->
### Fixed issues
#20537
## Details
### Before: What was the problem?
<!-- DESCRIBE THE BUG OR REQUIREMENT HERE. -->
<!-- ADD SCREENSHOT HERE IF APPLICABLE. -->
### After: How does it behave after the fixing?
<!-- THE RESULT AFTER FIXING AND A SIMPLE EXPLANATION ABOUT HOW IT IS FIXED. -->
<!-- ADD SCREENSHOT HERE IF APPLICABLE. -->
## Document Info
One of the following should be checked.
- [x] This PR doesn't relate to document changes
- [ ] The document should be updated later
- [ ] The document changes have been made in apache/echarts-doc#xxx
## Misc
### ZRender Changes
- [ ] This PR depends on ZRender changes (ecomfe/zrender#xxx).
### Related test cases or examples to use the new APIs
N.A.
## Others
### Merging options
- [ ] Please squash the commits into a single one when merging.
### Other information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
Re: [PR] fix(log): barMinHeight not work with startvalue greater than 10 [echarts]
Posted by "sz-p (via GitHub)" <gi...@apache.org>.
sz-p commented on PR #20541:
URL: https://github.com/apache/echarts/pull/20541#issuecomment-2500698666
## Direct cause:
Axis: `type: log` not start with `0` in default like `type: value`.
It is start with `mathLog(Math.max(0, start)) / base` in https://github.com/apache/echarts/blob/master/src/scale/Log.ts#L90
## Root cause:
`startValue` is not equal the start value in Axis extent. [getValueAxisStart](https://github.com/apache/echarts/blob/master/src/layout/barGrid.ts#L604)
## P.S.
which one has higher priority? `barMinHeight` or `min` in axis.
Is this right?
---
`startAngle` is not work with `min` in `coordinateSystem: 'polar'`
https://echarts.apache.org/examples/zh/editor.html?c=bar-polar-label-tangential&code=PYBwLglsB2AEC8sDeAoWtJgDYFMBcsA2musiaRjgB5gEDkAKgIbQDmO0kTWsACsFiYAnWACFhsADJMARjh78AzhEgxYACgC2EACY7cASjrlYAXxIBdADQkQA4QVQUhTHRACuigoQDMABitYOgAOPwBSOgsSUxt0FlZcAEEqCC8yCk0mKgIAVgCTRTBhMES2XAIATnyMiGgCAEY_aNjYFzdPZNTHEzAATxB8IIBjJjAcVmAhXroW9B1Rpm86JhmgmVW6IY2dSOaSMGABSBBHGJJFHCEIHDSnUj6B-hlhGZN5ou96wMbAgCYA2D-awmIaHIRuaCjHAAZV6hRwmnodkEQleFEEciw3Qo6EUAAtgAB3AhgITuHCzUh2ZSqOpBbR6XBonEAM0mmTAYyE9CQMlMjiGpmMFHM6HMpgA3EA
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
Re: [PR] fix(log): barMinHeight not work with startvalue greater than 10 [echarts]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20541:
URL: https://github.com/apache/echarts/pull/20541#issuecomment-2502940156
The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-20541@aad4735
<!-- ECHARTS_PR_PREVIEW -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
Re: [PR] fix(log): barMinHeight not work with startvalue greater than 10 [echarts]
Posted by "echarts-bot[bot] (via GitHub)" <gi...@apache.org>.
echarts-bot[bot] commented on PR #20541:
URL: https://github.com/apache/echarts/pull/20541#issuecomment-2500661594
Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/echarts/wiki/How-to-make-a-pull-request).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org