You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by Bruno Roustant <br...@gmail.com> on 2024/05/18 15:25:07 UTC

Join module dependency

The facet module has a dependency on com.carrotsearch:hppc.

Is it possible to add the same dependency to the join module ? What is the
rule ?

Thanks

Bruno

Re: Join module dependency

Posted by Dawid Weiss <da...@gmail.com>.
I don't mind at all. :)

On Sun, May 19, 2024 at 5:36 PM Bruno Roustant <br...@gmail.com>
wrote:

> It seems it would be nice to have hppc in the join and spatial modules.
>
> Le dim. 19 mai 2024 à 14:46, Dawid Weiss <da...@gmail.com> a écrit :
>
>>
>> I don't think there are any rules other than common sense - Lucene is
>> used in so many different environments and subprojects that any dependency
>> will eventually create a headache and a conflict. So no dependencies at all
>> is great, if it can be achieved. If it's just one or two classes we care
>> about then perhaps just moving them over is sufficient? Since we already
>> have a HPPC dependency in another module, perhaps it's ok to propagate it
>> to other modules? I'm not really sure how much impact it'll have downstream.
>>
>> D.
>>
>> On Sat, May 18, 2024 at 5:26 PM Bruno Roustant <br...@gmail.com>
>> wrote:
>>
>>> The facet module has a dependency on com.carrotsearch:hppc.
>>>
>>> Is it possible to add the same dependency to the join module ? What is
>>> the rule ?
>>>
>>> Thanks
>>>
>>> Bruno
>>>
>>

Re: Join module dependency

Posted by Bruno Roustant <br...@gmail.com>.
It seems it would be nice to have hppc in the join and spatial modules.

Le dim. 19 mai 2024 à 14:46, Dawid Weiss <da...@gmail.com> a écrit :

>
> I don't think there are any rules other than common sense - Lucene is used
> in so many different environments and subprojects that any dependency will
> eventually create a headache and a conflict. So no dependencies at all is
> great, if it can be achieved. If it's just one or two classes we care about
> then perhaps just moving them over is sufficient? Since we already have a
> HPPC dependency in another module, perhaps it's ok to propagate it to other
> modules? I'm not really sure how much impact it'll have downstream.
>
> D.
>
> On Sat, May 18, 2024 at 5:26 PM Bruno Roustant <br...@gmail.com>
> wrote:
>
>> The facet module has a dependency on com.carrotsearch:hppc.
>>
>> Is it possible to add the same dependency to the join module ? What is
>> the rule ?
>>
>> Thanks
>>
>> Bruno
>>
>

Re: Join module dependency

Posted by Dawid Weiss <da...@gmail.com>.
I don't think there are any rules other than common sense - Lucene is used
in so many different environments and subprojects that any dependency will
eventually create a headache and a conflict. So no dependencies at all is
great, if it can be achieved. If it's just one or two classes we care about
then perhaps just moving them over is sufficient? Since we already have a
HPPC dependency in another module, perhaps it's ok to propagate it to other
modules? I'm not really sure how much impact it'll have downstream.

D.

On Sat, May 18, 2024 at 5:26 PM Bruno Roustant <br...@gmail.com>
wrote:

> The facet module has a dependency on com.carrotsearch:hppc.
>
> Is it possible to add the same dependency to the join module ? What is the
> rule ?
>
> Thanks
>
> Bruno
>

Re: Join module dependency

Posted by Michael Sokolov <ms...@gmail.com>.
I'm pretty sure it's only in core that we follow the no dependencies rule.

On Sat, May 18, 2024, 11:25 AM Bruno Roustant <br...@gmail.com>
wrote:

> The facet module has a dependency on com.carrotsearch:hppc.
>
> Is it possible to add the same dependency to the join module ? What is the
> rule ?
>
> Thanks
>
> Bruno
>