You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by Yunkai Zhang <yu...@gmail.com> on 2013/01/25 12:55:15 UTC

I was confused by AlarmListTable in overviewRecord

Hi folks:

What is the purpose of AlarmListTable in overviewRecord?  Does it outdate?

It seems that, in the following steps:

1. Objects of AlarmListTable is added into overviewRecord::nodeAlarms and
overviewRecord::notFoundAlarms lists by overviewAlarmCallback()/addAlarm()
2. And then, they are removed by checkAlarms()/addSelfRecord()

AlarmListTable does nothing at all.

If it's obsolete, I'm going to clean it.

-- 
Yunkai Zhang
Work at Taobao

Re: I was confused by AlarmListTable in overviewRecord

Posted by Yunkai Zhang <yu...@gmail.com>.
On Wed, Jan 30, 2013 at 1:47 PM, James Peach <jp...@apache.org> wrote:

> On 25/01/2013, at 3:55 AM, Yunkai Zhang <yu...@gmail.com> wrote:
>
> > Hi folks:
> >
> > What is the purpose of AlarmListTable in overviewRecord?  Does it
> outdate?
> >
> > It seems that, in the following steps:
> >
> > 1. Objects of AlarmListTable is added into overviewRecord::nodeAlarms and
> > overviewRecord::notFoundAlarms lists by
> overviewAlarmCallback()/addAlarm()
> > 2. And then, they are removed by checkAlarms()/addSelfRecord()
> >
> > AlarmListTable does nothing at all.
> >
> > If it's obsolete, I'm going to clean it.
>
> It looks like dead code to me. I'm going to guess it was once used for the
> Inktomi cache appliance? I would not be sorry to see all the web management
> removed ...
>

Thanks for your reply:)

I'll submit a patch to clean it.


>
> J




-- 
Yunkai Zhang
Work at Taobao

Re: I was confused by AlarmListTable in overviewRecord

Posted by James Peach <jp...@apache.org>.
On 25/01/2013, at 3:55 AM, Yunkai Zhang <yu...@gmail.com> wrote:

> Hi folks:
> 
> What is the purpose of AlarmListTable in overviewRecord?  Does it outdate?
> 
> It seems that, in the following steps:
> 
> 1. Objects of AlarmListTable is added into overviewRecord::nodeAlarms and
> overviewRecord::notFoundAlarms lists by overviewAlarmCallback()/addAlarm()
> 2. And then, they are removed by checkAlarms()/addSelfRecord()
> 
> AlarmListTable does nothing at all.
> 
> If it's obsolete, I'm going to clean it.

It looks like dead code to me. I'm going to guess it was once used for the Inktomi cache appliance? I would not be sorry to see all the web management removed ...

J