[GitHub] [rocketmq] complone commented on a diff in pull request #4393: [iSSUE-4256] Concurrent execution of methods that support DefaultMQAdminExtImpl

[GitBox <gi...@apache.org>]

complone commented on code in PR #4393:
URL: https://github.com/apache/rocketmq/pull/4393#discussion_r909204462


##########
client/src/main/java/org/apache/rocketmq/client/impl/MQClientAPIImpl.java:
##########
@@ -1697,6 +1697,8 @@ public ClusterInfo getBrokerClusterInfo(
         switch (response.getCode()) {
             case ResponseCode.SUCCESS: {
                 return ClusterInfo.decode(response.getBody(), ClusterInfo.class);
+            } case ResponseCode.BROKER_NOT_EXIST: {

Review Comment:
   @ferrirW  The reason for the modification is that when the broker sends the RemoteingCommand to the Nameserver, the related broker information may not be collected from the NameServer because the netty channel is in the wait state, so an exception is thrown here. Currently only exposed in multi-threaded scenarios. If there is no problem after migrating the test class I will remove this case



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org