[GitHub] [incubator-netbeans] matthiasblaesing commented on a change in pull request #1182: [NETBEANS-2327] fix bug to avoid program crash

[GitBox <gi...@apache.org>]

matthiasblaesing commented on a change in pull request #1182: [NETBEANS-2327] fix bug to avoid program crash
URL: https://github.com/apache/incubator-netbeans/pull/1182#discussion_r272843696
 
 

 ##########
 File path: java/performance/src/org/netbeans/modules/performance/utilities/CommonUtilities.java
 ##########
 @@ -279,7 +279,7 @@ public static String jEditProjectOpen() {
             ZipEntry entry;
             while ((entry = zis.getNextEntry()) != null) {
                 if (entry.isDirectory()) {
-                    new File(System.getProperty("nbjunit.workdir") + File.separator + ".." + File.separator + "data" + File.separator + entry.getName()).mkdir();
+                    new File(System.getProperty("nbjunit.workdir") + File.separator + ".." + File.separator + "data" + File.separator + entry.getName()).mkdirs();
 
 Review comment:
   This assumes, that the upper levels of the directory where not yet created. The order in the zip is off. If that is the case, it will still blow in line 287, when the content file is to be written to the not existing directory.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists