You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/08/12 00:49:38 UTC
[GitHub] [beam] dxichen commented on a diff in pull request #22693: Upgrade org.apache.samza to 1.7
dxichen commented on code in PR #22693:
URL: https://github.com/apache/beam/pull/22693#discussion_r944038904
##########
runners/samza/src/main/java/org/apache/beam/runners/samza/SamzaJobServerDriver.java:
##########
@@ -17,23 +17,52 @@
*/
package org.apache.beam.runners.samza;
+import javax.annotation.Nullable;
import org.apache.beam.runners.jobsubmission.JobServerDriver;
import org.apache.beam.sdk.fn.server.ServerFactory;
import org.apache.beam.sdk.io.FileSystems;
import org.apache.beam.sdk.options.PipelineOptions;
import org.apache.beam.sdk.options.PipelineOptionsFactory;
import org.kohsuke.args4j.CmdLineException;
import org.kohsuke.args4j.CmdLineParser;
+import org.kohsuke.args4j.Option;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
/** Driver program that starts a job server for the Samza runner. */
+@SuppressWarnings({
+ "nullness" // TODO(https://github.com/apache/beam/issues/20497)
+})
public class SamzaJobServerDriver extends JobServerDriver {
private static final Logger LOG = LoggerFactory.getLogger(SamzaJobServerDriver.class);
/** Samza runner-specific Configuration for the jobServer. */
- public static class SamzaServerConfiguration extends ServerConfiguration {}
+ public static class SamzaServerConfiguration extends ServerConfiguration {
+ @Option(
+ name = "--job-non-logged-store-base-dir",
+ usage =
+ "Base dir for non logger store, job name will be automatically "
Review Comment:
s/logger/logged
##########
runners/samza/src/main/java/org/apache/beam/runners/samza/SamzaJobServerDriver.java:
##########
@@ -17,23 +17,52 @@
*/
package org.apache.beam.runners.samza;
+import javax.annotation.Nullable;
import org.apache.beam.runners.jobsubmission.JobServerDriver;
import org.apache.beam.sdk.fn.server.ServerFactory;
import org.apache.beam.sdk.io.FileSystems;
import org.apache.beam.sdk.options.PipelineOptions;
import org.apache.beam.sdk.options.PipelineOptionsFactory;
import org.kohsuke.args4j.CmdLineException;
import org.kohsuke.args4j.CmdLineParser;
+import org.kohsuke.args4j.Option;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
/** Driver program that starts a job server for the Samza runner. */
+@SuppressWarnings({
+ "nullness" // TODO(https://github.com/apache/beam/issues/20497)
+})
public class SamzaJobServerDriver extends JobServerDriver {
private static final Logger LOG = LoggerFactory.getLogger(SamzaJobServerDriver.class);
/** Samza runner-specific Configuration for the jobServer. */
- public static class SamzaServerConfiguration extends ServerConfiguration {}
+ public static class SamzaServerConfiguration extends ServerConfiguration {
+ @Option(
+ name = "--job-non-logged-store-base-dir",
+ usage =
+ "Base dir for non logger store, job name will be automatically "
+ + "appended after job submission.")
+ private String jobNonLoggedStoreBaseDir = null;
+
+ @Nullable
+ String getJobNonLoggedStoreBaseDir() {
+ return jobNonLoggedStoreBaseDir;
+ }
+
+ @Option(
+ name = "--job-logged-store-base-dir",
+ usage =
+ "Base dir for logger store, job name will be automatically "
Review Comment:
s/logger/logged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org