You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/10/22 12:46:04 UTC
[GitHub] [kafka] chia7712 commented on a change in pull request #9477: MINOR: TopologyTestDriver should not require dummy parameters
chia7712 commented on a change in pull request #9477:
URL: https://github.com/apache/kafka/pull/9477#discussion_r510126004
##########
File path: streams/test-utils/src/main/java/org/apache/kafka/streams/TopologyTestDriver.java
##########
@@ -297,7 +297,15 @@ public TopologyTestDriver(final Topology topology,
private TopologyTestDriver(final InternalTopologyBuilder builder,
final Properties config,
final long initialWallClockTimeMs) {
- final StreamsConfig streamsConfig = new ClientUtils.QuietStreamsConfig(config);
+ final Properties configCopy = new Properties();
+ configCopy.putAll(config);
+ if (!configCopy.containsKey(StreamsConfig.BOOTSTRAP_SERVERS_CONFIG)) {
Review comment:
this comment (https://github.com/apache/kafka/blob/trunk/streams/test-utils/src/main/java/org/apache/kafka/streams/TopologyTestDriver.java#L138) can be removed since it is not necessary anymore.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org