Re: Review Request 23462: Added composing containerizer and --containerizers flag.

[Benjamin Hindman <be...@berkeley.edu>]

> On July 16, 2014, 6:33 p.m., Ian Downes wrote:
> > src/slave/containerizer/composing.hpp, line 1
> > <https://reviews.apache.org/r/23462/diff/1/?file=629883#file629883line1>
> >
> >     others are *_containerizer, e.g., mesos_containerizer, external_containerizer. What about composing_containerizer for consistency?

The mesos_containerizer.hpp|cpp got moved to /mesos directory, and we should probably do the same with external or rename it without the _containerizer suffix. We also just introduced docker.hpp|cpp rather than docker_containerizer.hpp|cpp too.


> On July 16, 2014, 6:33 p.m., Ian Downes wrote:
> > src/slave/containerizer/composing.cpp, line 260
> > <https://reviews.apache.org/r/23462/diff/1/?file=629884#file629884line260>
> >
> >     What happens if --containerizers is changed? i.e., you have running containers that were started with a containerizer that now isn't present? You're only recovering containers for containerizers that you're told to IIUC...?

That's a good point. I've added MESOS-1663 and put a comment in Containerizer::create. This existed even before these changes though, for just ExternalContainerizer versus MesosContainerizer too.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23462/#review47917
-----------------------------------------------------------


On July 14, 2014, 10:30 p.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23462/
> -----------------------------------------------------------
> 
> (Updated July 14, 2014, 10:30 p.m.)
> 
> 
> Review request for mesos, Ian Downes and Jie Yu.
> 
> 
> Bugs: MESOS-1527
>     https://issues.apache.org/jira/browse/MESOS-1527
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Next part of MESOS-1527, see dependent review 23461 for the first phase.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 2c7bfc57103c47523466c297f2596eaf4eb55c3c 
>   src/slave/containerizer/composing.hpp PRE-CREATION 
>   src/slave/containerizer/composing.cpp PRE-CREATION 
>   src/slave/containerizer/containerizer.cpp 1b71f33b430645300d171eadc9f7de96d28adf60 
>   src/slave/flags.hpp 1fe7b7da5aaa221ed6b94203b1189a80b14edd25 
> 
> Diff: https://reviews.apache.org/r/23462/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>