You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by wjur <gi...@git.apache.org> on 2016/02/11 11:59:45 UTC
[GitHub] spark pull request: [Docs] Update cache()'s storage level to be co...
GitHub user wjur opened a pull request:
https://github.com/apache/spark/pull/11172
[Docs] Update cache()'s storage level to be consistent with the code
The docs say that the default storage level is MEMORY_ONLY,
but in fact it is MEMORY_AND_DISK. This commit fixes the
inconsistency between the code and the docs.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/wjur/spark wjur/caching_default_level
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/11172.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #11172
----
commit 7ab9dad11d802e99d70812063fede6ce800baec4
Author: Wojciech Jurczyk <wo...@codilime.com>
Date: 2016-02-11T10:54:30Z
[Docs] Update cache()'s storage level to be consistent with the code
The docs say that the default storage level is MEMORY_ONLY,
but in fact it is MEMORY_AND_DISK. This commit fixes the
inconsistency between the code and the docs.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [Docs] Update cache()'s storage level to be co...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11172#issuecomment-182810551
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [Docs] Update cache()'s storage level to be co...
Posted by wjur <gi...@git.apache.org>.
Github user wjur commented on the pull request:
https://github.com/apache/spark/pull/11172#issuecomment-183226607
@mateiz, I'm not sure who is responsible for the docs, but it it seems that you are the last one who edited the affected lines. I would be grateful if you could take a look at the PR. The inconsistency was introduced by PR #2686 (if that matters).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [Docs] Update cache()'s storage level to be co...
Posted by wjur <gi...@git.apache.org>.
Github user wjur commented on the pull request:
https://github.com/apache/spark/pull/11172#issuecomment-182810491
Please refer to
https://github.com/wjur/spark/blob/wjur/caching_default_level/sql/core/src/main/scala/org/apache/spark/sql/execution/CacheManager.scala#L84
and to
https://github.com/wjur/spark/blob/wjur/caching_default_level/sql/core/src/main/scala/org/apache/spark/sql/DataFrame.scala#L1601
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [Docs] Update cache()'s storage level to be co...
Posted by wjur <gi...@git.apache.org>.
Github user wjur commented on the pull request:
https://github.com/apache/spark/pull/11172#issuecomment-183272710
That's confusing... @srowen, you're correct. RDDs are not DataFrames. I'm really sorry for taking your time.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [Docs] Update cache()'s storage level to be co...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/11172#issuecomment-183265666
I don't think that's correct:
```
/** Persist this RDD with the default storage level (`MEMORY_ONLY`). */
def persist(): this.type = persist(StorageLevel.MEMORY_ONLY)
/** Persist this RDD with the default storage level (`MEMORY_ONLY`). */
def cache(): this.type = persist()
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [Docs] Update cache()'s storage level to be co...
Posted by wjur <gi...@git.apache.org>.
Github user wjur closed the pull request at:
https://github.com/apache/spark/pull/11172
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org