You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tooling.apache.org by sb...@apache.org on 2026/04/14 15:39:43 UTC

(tooling-trusted-releases) branch sbp updated: Remove UI access checks for POST routes

This is an automated email from the ASF dual-hosted git repository.

sbp pushed a commit to branch sbp
in repository https://gitbox.apache.org/repos/asf/tooling-trusted-releases.git


The following commit(s) were added to refs/heads/sbp by this push:
     new a54b4140 Remove UI access checks for POST routes
a54b4140 is described below

commit a54b414080be29ecf613d77702c7c5fa7a24ab91
Author: Sean B. Palmer <se...@miscoranda.com>
AuthorDate: Tue Apr 14 16:39:13 2026 +0100

    Remove UI access checks for POST routes
---
 atr/blueprints/post.py | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/atr/blueprints/post.py b/atr/blueprints/post.py
index 0a8a7e55..5b519e4d 100644
--- a/atr/blueprints/post.py
+++ b/atr/blueprints/post.py
@@ -28,7 +28,6 @@ import quart
 import atr.blueprints.common as common
 import atr.form
 import atr.log as log
-import atr.models.safe as safe
 import atr.web as web
 
 _BLUEPRINT_NAME: Final = "post_blueprint"
@@ -61,8 +60,8 @@ def typed(func: Callable[..., Any]) -> web.RouteFunction[Any]:
     - check_access is called automatically for committer routes with project_key
     """
     path, validated_params, literal_params, form_param, public = common.build_path(func)
-    project_key_var = next((name for name, t in validated_params if t is safe.ProjectKey), None)
-    check_access = (not public) and (project_key_var is not None)
+    # project_key_var = next((name for name, t in validated_params if t is safe.ProjectKey), None)
+    # check_access = (not public) and (project_key_var is not None)
     form_safe_params = common.safe_params_for_type(form_param[1]) if (form_param is not None) else []
 
     async def wrapper(*_args: Any, **kwargs: Any) -> Any:
@@ -70,8 +69,8 @@ def typed(func: Callable[..., Any]) -> web.RouteFunction[Any]:
         await common.validate_params(kwargs, validated_params)
         kwargs.update(literal_params)
 
-        if check_access and (enhanced_session is not None) and (project_key_var is not None):
-            await enhanced_session.check_access(str(kwargs[project_key_var]))
+        # if check_access and (enhanced_session is not None) and (project_key_var is not None):
+        #     await enhanced_session.check_access(str(kwargs[project_key_var]))
 
         if form_param is not None:
             form_param_name, form_cls = form_param


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@tooling.apache.org
For additional commands, e-mail: commits-help@tooling.apache.org