You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by "Prasad Mujumdar (Created) (JIRA)" <ji...@apache.org> on 2012/03/15 18:13:40 UTC
[jira] [Created] (FLUME-1031) Depricate code generated by Thrift
and Avro OG sources that is under com.cloudera package
Depricate code generated by Thrift and Avro OG sources that is under com.cloudera package
-----------------------------------------------------------------------------------------
Key: FLUME-1031
URL: https://issues.apache.org/jira/browse/FLUME-1031
Project: Flume
Issue Type: Bug
Components: Sinks+Sources
Affects Versions: v1.0.0
Reporter: Prasad Mujumdar
Assignee: Prasad Mujumdar
Fix For: v1.1.0, v1.2.0
There's some generated code for Flume OG thrift and avro sources that is under com.cloudera package (due to namespace dependencies). We need to deprecate the code.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-1031) Depricate code generated by Thrift
and Avro OG sources that is under com.cloudera package
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13232496#comment-13232496 ]
Hudson commented on FLUME-1031:
-------------------------------
Integrated in flume-trunk #131 (See [https://builds.apache.org/job/flume-trunk/131/])
FLUME-1031. Depricate generated code not in org.apache namespace.
(Prasad Mujumdar via Arvind Prabhakar) (Revision 1302303)
Result = SUCCESS
arvind : http://svn.apache.org/viewvc/?view=rev&rev=1302303
Files :
* /incubator/flume/trunk/flume-ng-dist/pom.xml
* /incubator/flume/trunk/flume-ng-legacy-sources/flume-thrift-source/src/main/java/com/cloudera/flume/handlers/thrift/ThriftFlumeEvent.java
* /incubator/flume/trunk/flume-ng-legacy-sources/flume-thrift-source/src/main/java/com/cloudera/flume/handlers/thrift/ThriftFlumeEventServer.java
* /incubator/flume/trunk/flume-ng-legacy-sources/flume-thrift-source/src/main/java/org/apache/flume/source/thriftLegacy/ThriftLegacySource.java
> Depricate code generated by Thrift and Avro OG sources that is under com.cloudera package
> -----------------------------------------------------------------------------------------
>
> Key: FLUME-1031
> URL: https://issues.apache.org/jira/browse/FLUME-1031
> Project: Flume
> Issue Type: Bug
> Components: Sinks+Sources
> Affects Versions: v1.0.0
> Reporter: Prasad Mujumdar
> Assignee: Prasad Mujumdar
> Fix For: v1.1.0, v1.2.0
>
> Attachments: FLUME-1031.patch
>
>
> There's some generated code for Flume OG thrift and avro sources that is under com.cloudera package (due to namespace dependencies). We need to deprecate the code.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-1031) Depricate code generated by Thrift
and Avro OG sources that is under com.cloudera package
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13230423#comment-13230423 ]
jiraposter@reviews.apache.org commented on FLUME-1031:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4367/
-----------------------------------------------------------
Review request for Arvind Prabhakar.
Summary
-------
Deprecate the thrift generated com.cloudera package classes.
Also the legacy sources were not added to the dependency in the dist pom (opps ;) ), so fixed that as well.
This addresses bug FLUME-1031.
https://issues.apache.org/jira/browse/FLUME-1031
Diffs
-----
flume-ng-dist/pom.xml f7e0dd9
flume-ng-legacy-sources/flume-thrift-source/src/main/java/com/cloudera/flume/handlers/thrift/ThriftFlumeEvent.java c8690c4
flume-ng-legacy-sources/flume-thrift-source/src/main/java/com/cloudera/flume/handlers/thrift/ThriftFlumeEventServer.java c95a96c
flume-ng-legacy-sources/flume-thrift-source/src/main/java/org/apache/flume/source/thriftLegacy/ThriftLegacySource.java fbf7362
Diff: https://reviews.apache.org/r/4367/diff
Testing
-------
no new test added
Thanks,
Prasad
> Depricate code generated by Thrift and Avro OG sources that is under com.cloudera package
> -----------------------------------------------------------------------------------------
>
> Key: FLUME-1031
> URL: https://issues.apache.org/jira/browse/FLUME-1031
> Project: Flume
> Issue Type: Bug
> Components: Sinks+Sources
> Affects Versions: v1.0.0
> Reporter: Prasad Mujumdar
> Assignee: Prasad Mujumdar
> Fix For: v1.1.0, v1.2.0
>
>
> There's some generated code for Flume OG thrift and avro sources that is under com.cloudera package (due to namespace dependencies). We need to deprecate the code.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FLUME-1031) Depricate code generated by Thrift
and Avro OG sources that is under com.cloudera package
Posted by "Prasad Mujumdar (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Prasad Mujumdar updated FLUME-1031:
-----------------------------------
Status: Patch Available (was: Open)
> Depricate code generated by Thrift and Avro OG sources that is under com.cloudera package
> -----------------------------------------------------------------------------------------
>
> Key: FLUME-1031
> URL: https://issues.apache.org/jira/browse/FLUME-1031
> Project: Flume
> Issue Type: Bug
> Components: Sinks+Sources
> Affects Versions: v1.0.0
> Reporter: Prasad Mujumdar
> Assignee: Prasad Mujumdar
> Fix For: v1.1.0, v1.2.0
>
> Attachments: FLUME-1031.patch
>
>
> There's some generated code for Flume OG thrift and avro sources that is under com.cloudera package (due to namespace dependencies). We need to deprecate the code.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FLUME-1031) Depricate code generated by Thrift
and Avro OG sources that is under com.cloudera package
Posted by "Prasad Mujumdar (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Prasad Mujumdar updated FLUME-1031:
-----------------------------------
Attachment: FLUME-1031.patch
> Depricate code generated by Thrift and Avro OG sources that is under com.cloudera package
> -----------------------------------------------------------------------------------------
>
> Key: FLUME-1031
> URL: https://issues.apache.org/jira/browse/FLUME-1031
> Project: Flume
> Issue Type: Bug
> Components: Sinks+Sources
> Affects Versions: v1.0.0
> Reporter: Prasad Mujumdar
> Assignee: Prasad Mujumdar
> Fix For: v1.1.0, v1.2.0
>
> Attachments: FLUME-1031.patch
>
>
> There's some generated code for Flume OG thrift and avro sources that is under com.cloudera package (due to namespace dependencies). We need to deprecate the code.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FLUME-1031) Depricate code generated by Thrift
and Avro OG sources that is under com.cloudera package
Posted by "Arvind Prabhakar (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arvind Prabhakar updated FLUME-1031:
------------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
Patch committed to trunk and 1.1.0 branch. Thanks Prasad!
> Depricate code generated by Thrift and Avro OG sources that is under com.cloudera package
> -----------------------------------------------------------------------------------------
>
> Key: FLUME-1031
> URL: https://issues.apache.org/jira/browse/FLUME-1031
> Project: Flume
> Issue Type: Bug
> Components: Sinks+Sources
> Affects Versions: v1.0.0
> Reporter: Prasad Mujumdar
> Assignee: Prasad Mujumdar
> Fix For: v1.1.0, v1.2.0
>
> Attachments: FLUME-1031.patch
>
>
> There's some generated code for Flume OG thrift and avro sources that is under com.cloudera package (due to namespace dependencies). We need to deprecate the code.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-1031) Depricate code generated by Thrift
and Avro OG sources that is under com.cloudera package
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13231827#comment-13231827 ]
jiraposter@reviews.apache.org commented on FLUME-1031:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4367/#review6061
-----------------------------------------------------------
Ship it!
+1. Thanks for the patch Prasad - please attach it to the Jira.
- Arvind
On 2012-03-15 18:55:53, Prasad Mujumdar wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4367/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-03-15 18:55:53)
bq.
bq.
bq. Review request for Arvind Prabhakar.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Deprecate the thrift generated com.cloudera package classes.
bq. Also the legacy sources were not added to the dependency in the dist pom (opps ;) ), so fixed that as well.
bq.
bq.
bq. This addresses bug FLUME-1031.
bq. https://issues.apache.org/jira/browse/FLUME-1031
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. flume-ng-dist/pom.xml f7e0dd9
bq. flume-ng-legacy-sources/flume-thrift-source/src/main/java/com/cloudera/flume/handlers/thrift/ThriftFlumeEvent.java c8690c4
bq. flume-ng-legacy-sources/flume-thrift-source/src/main/java/com/cloudera/flume/handlers/thrift/ThriftFlumeEventServer.java c95a96c
bq. flume-ng-legacy-sources/flume-thrift-source/src/main/java/org/apache/flume/source/thriftLegacy/ThriftLegacySource.java fbf7362
bq.
bq. Diff: https://reviews.apache.org/r/4367/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. no new test added
bq.
bq.
bq. Thanks,
bq.
bq. Prasad
bq.
bq.
> Depricate code generated by Thrift and Avro OG sources that is under com.cloudera package
> -----------------------------------------------------------------------------------------
>
> Key: FLUME-1031
> URL: https://issues.apache.org/jira/browse/FLUME-1031
> Project: Flume
> Issue Type: Bug
> Components: Sinks+Sources
> Affects Versions: v1.0.0
> Reporter: Prasad Mujumdar
> Assignee: Prasad Mujumdar
> Fix For: v1.1.0, v1.2.0
>
>
> There's some generated code for Flume OG thrift and avro sources that is under com.cloudera package (due to namespace dependencies). We need to deprecate the code.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira