You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "parveensania (via GitHub)" <gi...@apache.org> on 2026/05/21 18:11:01 UTC
[PR] Fix data_race condition in WindmillStreamSenderTest [beam]
parveensania opened a new pull request, #38589:
URL: https://github.com/apache/beam/pull/38589
Instead of memoizing Backoff constructed instance which is not thread-safe, memoize the builder config instead and return isolated BackOff instance for each individual stream.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix data_race condition in WindmillStreamSenderTest [beam]
Posted by "parveensania (via GitHub)" <gi...@apache.org>.
parveensania commented on code in PR #38589:
URL: https://github.com/apache/beam/pull/38589#discussion_r3283476149
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/client/grpc/GrpcWindmillStreamFactory.java:
##########
@@ -117,13 +117,12 @@ private GrpcWindmillStreamFactory(
this.streamingRpcBatchLimit = streamingRpcBatchLimit;
this.windmillMessagesBetweenIsReadyChecks = windmillMessagesBetweenIsReadyChecks;
// Configure backoff to retry calls forever, with a maximum sane retry interval.
- this.grpcBackOff =
+ Supplier<FluentBackoff> backoffConfig =
Suppliers.memoize(
- () ->
- FluentBackoff.DEFAULT
- .withInitialBackoff(MIN_BACKOFF)
- .withMaxBackoff(maxBackOffSupplier.get())
- .backoff());
+ () -> FluentBackoff.DEFAULT
+ .withInitialBackoff(MIN_BACKOFF)
+ .withMaxBackoff(maxBackOffSupplier.get()));
+ this.grpcBackOff = () -> backoffConfig.get().backoff();
Review Comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix data_race condition in WindmillStreamSenderTest [beam]
Posted by "gemini-code-assist[bot] (via GitHub)" <gi...@apache.org>.
gemini-code-assist[bot] commented on PR #38589:
URL: https://github.com/apache/beam/pull/38589#issuecomment-4511248576
## Summary of Changes
Hello, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses a data race condition identified in the Windmill stream sender logic. By refactoring the initialization of the backoff mechanism, the implementation now avoids sharing non-thread-safe instances across streams, instead generating isolated instances from a cached configuration.
### Highlights
* **Thread-safety improvement**: Replaced the memoized BackOff instance with a memoized FluentBackoff configuration to ensure thread-safe creation of backoff instances for individual streams.
<details>
<summary><b>New Features</b></summary>
🧠You can now enable **Memory** (public preview) to help **Gemini Code Assist** learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. **Click [here](https://codeassist.google/code-review/login) to enable Memory in your admin console.**
</details>
<details>
<summary><b>Using Gemini Code Assist</b></summary>
<br>
The full guide for Gemini Code Assist can be found on our [documentation page](https://developers.google.com/gemini-code-assist/docs/review-github-code), here are some quick tips.
<b>Invoking Gemini</b>
You can request assistance from Gemini at any point by creating a comment using either `/gemini <command>` or `@gemini-code-assist <command>`. Below is a summary of the supported commands on the current page.
Feature | Command | Description
--- | --- | ---
Code Review | `/gemini review` | Performs a code review for the current pull request in its current state.
Pull Request Summary | `/gemini summary` | Provides a summary of the current pull request in its current state.
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help | `/gemini help` | Displays a list of available commands.
<b>Customization</b>
To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a `.gemini/` folder in the base of the repository. Detailed instructions can be found [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github).
<b>Limitations & Feedback</b>
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up [here](https://google.qualtrics.com/jfe/form/SV_2cyuGuTWsEw84yG).
</details>
[^1]: Review the [Privacy Notices](https://policies.google.com/privacy), [Generative AI Prohibited Use Policy](https://policies.google.com/terms/generative-ai/use-policy), [Terms of Service](https://policies.google.com/terms), and learn how to configure Gemini Code Assist in GitHub [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). Gemini can make mistakes, so double check it and [use code with caution](https://support.google.com/legal/answer/13505487).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix data_race condition in WindmillStreamSenderTest [beam]
Posted by "gemini-code-assist[bot] (via GitHub)" <gi...@apache.org>.
gemini-code-assist[bot] commented on code in PR #38589:
URL: https://github.com/apache/beam/pull/38589#discussion_r3283391673
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/client/grpc/GrpcWindmillStreamFactory.java:
##########
@@ -117,13 +117,12 @@ private GrpcWindmillStreamFactory(
this.streamingRpcBatchLimit = streamingRpcBatchLimit;
this.windmillMessagesBetweenIsReadyChecks = windmillMessagesBetweenIsReadyChecks;
// Configure backoff to retry calls forever, with a maximum sane retry interval.
- this.grpcBackOff =
+ Supplier<FluentBackoff> backoffConfig =
Suppliers.memoize(
- () ->
- FluentBackoff.DEFAULT
- .withInitialBackoff(MIN_BACKOFF)
- .withMaxBackoff(maxBackOffSupplier.get())
- .backoff());
+ () -> FluentBackoff.DEFAULT
+ .withInitialBackoff(MIN_BACKOFF)
+ .withMaxBackoff(maxBackOffSupplier.get()));
+ this.grpcBackOff = () -> backoffConfig.get().backoff();
Review Comment:
The indentation of the newly added code is inconsistent with the surrounding code and the project's style. Continuation lines and lambda bodies should be properly indented (typically using a 4-space increment for each level).
```suggestion
Supplier<FluentBackoff> backoffConfig =
Suppliers.memoize(
() ->
FluentBackoff.DEFAULT
.withInitialBackoff(MIN_BACKOFF)
.withMaxBackoff(maxBackOffSupplier.get()));
this.grpcBackOff = () -> backoffConfig.get().backoff();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix data_race condition in WindmillStreamSenderTest [beam]
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm merged PR #38589:
URL: https://github.com/apache/beam/pull/38589
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix data_race condition in WindmillStreamSenderTest [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38589:
URL: https://github.com/apache/beam/pull/38589#issuecomment-4512600391
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment `assign set of reviewers`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix data_race condition in WindmillStreamSenderTest [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38589:
URL: https://github.com/apache/beam/pull/38589#issuecomment-4513307971
Assigning reviewers:
R: @tvalentyn added as fallback since no labels match configuration
Note: If you would like to opt out of this review, comment `assign to next reviewer`.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix data_race condition in WindmillStreamSenderTest [beam]
Posted by "parveensania (via GitHub)" <gi...@apache.org>.
parveensania commented on PR #38589:
URL: https://github.com/apache/beam/pull/38589#issuecomment-4512806482
Run Spotless PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org