You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2022/08/09 09:42:43 UTC

[GitHub] [ignite-3] ademakov commented on a diff in pull request #988: IGNITE-17400 Basic C++ binary tuple support

ademakov commented on code in PR #988:
URL: https://github.com/apache/ignite-3/pull/988#discussion_r941128514


##########
modules/platforms/cpp/CMakeLists.txt:
##########
@@ -0,0 +1,41 @@
+#

Review Comment:
   * It's weird for me too but this is how CMake works.
   * Probably you are right. I'd appreciate any advise on module placement. If client developers would re-use this module, what is the best location for them?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org