You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "sigram (via GitHub)" <gi...@apache.org> on 2026/05/25 11:43:36 UTC
[PR] SOLR-18252: Fix flaky test by avoiding race conditions. [solr]
sigram opened a new pull request, #4462:
URL: https://github.com/apache/solr/pull/4462
This fixes a flaky test. ArrayList has been replaced with a BlockingQueue, plus used a better approach to consuming the records being collected in the queue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-18252: Fix flaky test by avoiding race conditions. [solr]
Posted by "sigram (via GitHub)" <gi...@apache.org>.
sigram commented on PR #4462:
URL: https://github.com/apache/solr/pull/4462#issuecomment-4535341475
@epugh looks nice, good to know. But in this case the lambda is relatively large so I think it would be less readable than this explicit loop.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-18252: Fix flaky test by avoiding race conditions. [solr]
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh commented on PR #4462:
URL: https://github.com/apache/solr/pull/4462#issuecomment-4534785079
I have recently used TimeOut, and I was wondering if there are any strong patterns in how we use, because I thoguht I had seen a streamlined pattern then how hyou used it. I asked Claude for some help, and it reminde me we have done a couple of lamda uses with timeout:
```
TimeOut t = new TimeOut(5000, TimeUnit.MILLISECONDS, TimeSource.NANO_TIME);
t.waitFor("Timeout waiting for c1", () -> reader.getClusterState().getCollectionOrNull("c1") != null);
```
Not sure if that is useful at all to you, but I appreciate your working on the flaky test!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-18252: Fix flaky test by avoiding race conditions. [solr]
Posted by "sigram (via GitHub)" <gi...@apache.org>.
sigram merged PR #4462:
URL: https://github.com/apache/solr/pull/4462
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org