[jira] [Commented] (HIVE-5413) StorageDelegationAuthorizationProvider uses non-existent org.apache.hive.hcatalog.hbase.HBaseHCatStorageHandler

["Hive QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-5413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13784039#comment-13784039 ] 

Hive QA commented on HIVE-5413:
-------------------------------



{color:green}Overall{color}: +1 all checks pass

Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12606251/HIVE-5413.patch

{color:green}SUCCESS:{color} +1 4043 tests passed

Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/995/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/995/console

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}

This message is automatically generated.

> StorageDelegationAuthorizationProvider uses non-existent org.apache.hive.hcatalog.hbase.HBaseHCatStorageHandler
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: HIVE-5413
>                 URL: https://issues.apache.org/jira/browse/HIVE-5413
>             Project: Hive
>          Issue Type: Bug
>          Components: HCatalog
>    Affects Versions: 0.12.0
>            Reporter: Eugene Koifman
>            Assignee: Eugene Koifman
>             Fix For: 0.12.0
>
>         Attachments: HIVE-5413.patch
>
>
> org.apache.hive.hcatalog.security.StorageDelegationAuthorizationProvider
> has a block like this:
>   static {
>     registerAuthProvider("org.apache.hadoop.hive.hbase.HBaseStorageHandler",
>       "org.apache.hive.hcatalog.hbase.HBaseAuthorizationProvider");
>     registerAuthProvider("org.apache.hive.hcatalog.hbase.HBaseHCatStorageHandler",
>       "org.apache.hive.hcatalog.hbase.HBaseAuthorizationProvider");
>   }
> In reality, HBaseHCatStorageHandler and HBaseAuthorizationProvider only exist in org.apache.hcatalog
> This should be fixed by removing org.apache.hive.hcatalog.security.StorageDelegationAuthorizationProvider.  We have org.apache.hcatalog.security.StorageDelegationAuthorizationProvider which is only used by now deprecated hcatalog version of hbase storage handler.
> Also,
> hcatalog/src/test/e2e/hcatalog/tests/pig.conf & hadoop.conf have the same problem.  
> In addition, the tests affected in pig.conf/hadoop.conf should use org.apache.hcatalog.pig.HCatLoader/HCatStorer.
> Finally, hadoop.conf#Hadoop_HBase is using org.apache.hive.hcatalog.utils.HBaseReadWrite which internally refers to org.apache.hive.hcatalog.* classes.  The later should only use org.apache.hcatalog.* since it's using HBaseHCatStoreageHandler.  Also, should move HBaseReadWrite to org.apache.hcatalog for clarity.
> (see the last paragraph of the Description of HIVE-5274)



--
This message was sent by Atlassian JIRA
(v6.1#6144)