[GitHub] pnowojski commented on a change in pull request #6787: [FLINK-8577][table] Implement proctime DataStream to Table upsert conversion

[GitBox <gi...@apache.org>]

pnowojski commented on a change in pull request #6787: [FLINK-8577][table] Implement proctime DataStream to Table upsert conversion
URL: https://github.com/apache/flink/pull/6787#discussion_r253463228
 
 

 ##########
 File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/StreamTableEnvironment.scala
 ##########
 @@ -426,7 +426,7 @@ abstract class StreamTableEnvironment(
     converterFunction match {
 
       case Some(func) =>
-        new CRowMapRunner[OUT](func.name, func.code, func.returnType)
+        new CRowToExternalTypeMapRunner[OUT](func.name, func.code, func.returnType)
 
 Review comment:
   Please, as a general rule do not mix simple refactorings like class renames and moving classes around with functional changes. Embedding those two things inside one commit makes sense only if the refactoring/rename is tightly coupled with the functional change and here it doesn't seem so.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services