You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/07/14 18:13:03 UTC
[GitHub] [hudi] zhedoubushishi opened a new pull request #1831: [HUDI-1087] Handle decimal type for realtime record reader with SparkSQL
zhedoubushishi opened a new pull request #1831:
URL: https://github.com/apache/hudi/pull/1831
## *Tips*
- *Thank you very much for contributing to Apache Hudi.*
- *Please review https://hudi.apache.org/contributing.html before opening a pull request.*
## What is the purpose of the pull request
JIRA https://issues.apache.org/jira/browse/HUDI-1087
ISSUE https://github.com/apache/hudi/issues/1790
This [pr](https://github.com/apache/hudi/pull/1677/files) calls ```HiveDecimalWritable.enforcePrecisionScale``` to handle decimal type for Hive realtime querying. But ```HiveDecimalWritable.enforcePrecisionScale``` is only available for Hive 2.x, so when using SparkSQL (which uses ```1.2.1.spark2``` version), it will throw a ```methodNotFound``` error.
This PR replaces ```HiveDecimalWritable.enforcePrecisionScale``` with ```HiveDecimalUtils.enforcePrecisionScale``` which is compatible with both Hive 2.x and Hive 1.2.1.spark2.
## Brief change log
- Replaced ```HiveDecimalWritable.enforcePrecisionScale``` with ```HiveDecimalUtils.enforcePrecisionScale``` which is compatible with both Hive 2.x and Hive 1.2.1.spark2.
## Verify this pull request
This pull request is a trivial rework / code cleanup without any test coverage.
## Committer checklist
- [x] Has a corresponding JIRA in PR title & commit
- [x] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] vinothchandar commented on pull request #1831: [HUDI-1087] Handle decimal type for realtime record reader with SparkSQL
Posted by GitBox <gi...@apache.org>.
vinothchandar commented on pull request #1831:
URL: https://github.com/apache/hudi/pull/1831#issuecomment-658532404
cc @umehrot2 want to review this one?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] vinothchandar commented on pull request #1831: [HUDI-1087] Handle decimal type for realtime record reader with SparkSQL
Posted by GitBox <gi...@apache.org>.
vinothchandar commented on pull request #1831:
URL: https://github.com/apache/hudi/pull/1831#issuecomment-658532736
actually nvm.. its a small PR.. LGTM..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] bvaradar merged pull request #1831: [HUDI-1087] Handle decimal type for realtime record reader with SparkSQL
Posted by GitBox <gi...@apache.org>.
bvaradar merged pull request #1831:
URL: https://github.com/apache/hudi/pull/1831
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org