You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by Mark Thomas <ma...@apache.org> on 2024/02/04 19:54:25 UTC
Moving to Tomcat Native 1.3.x
Hi all,
AS you have probably noticed I am working on another round of Tomcat
Native releases.
We are overdue on switching to 1.3.x so I would like to propose the
following with this release round:
- create a new 1.3.x branch from the current 1.2.x HEAD
- update minimum OpenSSL to 1.1.1
- update minimum APR to 1.6.3
- remove code supporting OpenSSL < 1.1.1
The next 8.5.x and 9.0.x releases would then ship with Tomcat Native
1.3.0 but minimum required/recommended Tomcat Native versions would not
change.
Any objections?
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: Moving to Tomcat Native 1.3.x
Posted by Christopher Schultz <ch...@christopherschultz.net>.
Mark,
On 2/5/24 11:39, Mark Thomas wrote:
> On 05/02/2024 14:11, Christopher Schultz wrote:
>
>> I'm +1 to markt's suggestions for these releases, except maybe we
>> should leave 8.5.x with tcnative 1.2.x. I wouldn't want to break the
>> last few releases of 8.5.x for anybody.
>
> I think the chances of breakage are low as:
> - this is a fork from 1.2.x with the OpenSSL < 1.1.1 support removed
> - I'm testing the result with the 9.0.x unit tests (including the
> APR/Native connector) on multiple operating systems
>
> It is always possible that I broke something in an edge case but:
> - there is plenty of time to release a fix for 1.3.x before 8.5.x
> reaches EOL
> - updating to a new Tomcat Native is very simple even if an issue
> emerges after the last 8.5.x release
> - 1.3.x releases are likely to continue for the lifetime of 9.0.x which
> is probably another 3 years
>
> My current thinking is that I will switch 8.5.x to Tomcat Native 1.3.x
> as it means one less Tomcat Native release.
I was thinking we'd just let 8.5.x ride on it current tcnative release.
We only have, what... 2 more 8.5.x releases in total?
-chris
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: Moving to Tomcat Native 1.3.x
Posted by Mark Thomas <ma...@apache.org>.
On 05/02/2024 14:11, Christopher Schultz wrote:
> I'm +1 to markt's suggestions for these releases, except maybe we should
> leave 8.5.x with tcnative 1.2.x. I wouldn't want to break the last few
> releases of 8.5.x for anybody.
I think the chances of breakage are low as:
- this is a fork from 1.2.x with the OpenSSL < 1.1.1 support removed
- I'm testing the result with the 9.0.x unit tests (including the
APR/Native connector) on multiple operating systems
It is always possible that I broke something in an edge case but:
- there is plenty of time to release a fix for 1.3.x before 8.5.x
reaches EOL
- updating to a new Tomcat Native is very simple even if an issue
emerges after the last 8.5.x release
- 1.3.x releases are likely to continue for the lifetime of 9.0.x which
is probably another 3 years
My current thinking is that I will switch 8.5.x to Tomcat Native 1.3.x
as it means one less Tomcat Native release.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: Moving to Tomcat Native 1.3.x
Posted by Christopher Schultz <ch...@christopherschultz.net>.
All,
On 2/5/24 09:03, Christopher Schultz wrote:
> Mark,
>
> On 2/4/24 14:54, Mark Thomas wrote:
>> AS you have probably noticed I am working on another round of Tomcat
>> Native releases.
>>
>> We are overdue on switching to 1.3.x so I would like to propose the
>> following with this release round:
>>
>> - create a new 1.3.x branch from the current 1.2.x HEAD
>> - update minimum OpenSSL to 1.1.1
>
> What about going all the way up to OpenSSL *3.x* with tcnative 1.*3.x*?
>
> Is that too far?
>
>> - update minimum APR to 1.6.3
>> - remove code supporting OpenSSL < 1.1.1
>
> +1
>
>> The next 8.5.x and 9.0.x releases would then ship with Tomcat Native
>> 1.3.0 but minimum required/recommended Tomcat Native versions would
>> not change.
>
> If anyone else is interested in dumping OpenSSL 1.x, we'd have to make
> some changes, here. I think only 10.x and 11.x could upgrade without
> ruffling a lot of feathers.
Ignore this post. OpenSSL 3.xis what tcnative 2.x is for.
I'm +1 to markt's suggestions for these releases, except maybe we should
leave 8.5.x with tcnative 1.2.x. I wouldn't want to break the last few
releases of 8.5.x for anybody.
-chris
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: Moving to Tomcat Native 1.3.x
Posted by Christopher Schultz <ch...@christopherschultz.net>.
Mark,
On 2/4/24 14:54, Mark Thomas wrote:
> AS you have probably noticed I am working on another round of Tomcat
> Native releases.
>
> We are overdue on switching to 1.3.x so I would like to propose the
> following with this release round:
>
> - create a new 1.3.x branch from the current 1.2.x HEAD
> - update minimum OpenSSL to 1.1.1
What about going all the way up to OpenSSL *3.x* with tcnative 1.*3.x*?
Is that too far?
> - update minimum APR to 1.6.3
> - remove code supporting OpenSSL < 1.1.1
+1
> The next 8.5.x and 9.0.x releases would then ship with Tomcat Native
> 1.3.0 but minimum required/recommended Tomcat Native versions would not
> change.
If anyone else is interested in dumping OpenSSL 1.x, we'd have to make
some changes, here. I think only 10.x and 11.x could upgrade without
ruffling a lot of feathers.
-chris
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: Moving to Tomcat Native 1.3.x
Posted by Michael Osipov <mi...@apache.org>.
> >> The next 8.5.x and 9.0.x releases would then ship with Tomcat Native
> >> 1.3.0 but minimum required/recommended Tomcat Native versions would not
> >> change.
> >
> > I wouldn't bother with 8.5 and 1.3, I'd use 1.2.x until end of 8.5 and the put 1.2.x EOL.
>
> I'm still leaning towards switching 8.5.x to 1.3.0 but if the consensus
> is to stcik with the current 1.2.x release I'm fine with that. I'm
> mainly trying to avoid another 1.2.x release on top of all the other
> releases I am juggling at the moment.
I'd produce a last 1.2.x release to clean up/deliver the last changes from that branch to production, then the branch can be "closed".
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: Moving to Tomcat Native 1.3.x
Posted by Christopher Schultz <ch...@christopherschultz.net>.
Mark,
On 2/6/24 11:44, Mark Thomas wrote:
> On 06/02/2024 11:22, Michael Osipov wrote:
>> On 2024/02/04 19:54:25 Mark Thomas wrote:
>>> Hi all,
>>>
>>> AS you have probably noticed I am working on another round of Tomcat
>>> Native releases.
>>>
>>> We are overdue on switching to 1.3.x so I would like to propose the
>>> following with this release round:
>>>
>>> - create a new 1.3.x branch from the current 1.2.x HEAD
>>> - update minimum OpenSSL to 1.1.1
>>> - update minimum APR to 1.6.3
>>> - remove code supporting OpenSSL < 1.1.1
>>
>> Good, you have basically picked up
>> https://bz.apache.org/bugzilla/show_bug.cgi?id=67683.
>>
>> You have missed at least two spots:
>> *
>> https://github.com/apache/tomcat-native/blob/f6e1474c6b05e9cab0ad308647a3bde533c1cbce/native/build/tcnative.m4#L41-L45
>> *
>> https://github.com/apache/tomcat-native/blob/f6e1474c6b05e9cab0ad308647a3bde533c1cbce/native/src/jnilib.c#L77-L81
>
> Thanks for pointing those out. There may be more. I'll fix them as we
> spot them.
>
> I don't see either of these as reasons to halt the 1.3.0 release. If
> anyone has a different view, please comment on the vote thread.
>
>>> The next 8.5.x and 9.0.x releases would then ship with Tomcat Native
>>> 1.3.0 but minimum required/recommended Tomcat Native versions would not
>>> change.
>>
>> I wouldn't bother with 8.5 and 1.3, I'd use 1.2.x until end of 8.5 and
>> the put 1.2.x EOL.
>
> I'm still leaning towards switching 8.5.x to 1.3.0 but if the consensus
> is to stcik with the current 1.2.x release I'm fine with that. I'm
> mainly trying to avoid another 1.2.x release on top of all the other
> releases I am juggling at the moment.
I'm not sure I would bother. Just leave 8.5.x at the current libtcnative
level.
-chris
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: Moving to Tomcat Native 1.3.x
Posted by Mark Thomas <ma...@apache.org>.
On 06/02/2024 11:22, Michael Osipov wrote:
> On 2024/02/04 19:54:25 Mark Thomas wrote:
>> Hi all,
>>
>> AS you have probably noticed I am working on another round of Tomcat
>> Native releases.
>>
>> We are overdue on switching to 1.3.x so I would like to propose the
>> following with this release round:
>>
>> - create a new 1.3.x branch from the current 1.2.x HEAD
>> - update minimum OpenSSL to 1.1.1
>> - update minimum APR to 1.6.3
>> - remove code supporting OpenSSL < 1.1.1
>
> Good, you have basically picked up https://bz.apache.org/bugzilla/show_bug.cgi?id=67683.
>
> You have missed at least two spots:
> * https://github.com/apache/tomcat-native/blob/f6e1474c6b05e9cab0ad308647a3bde533c1cbce/native/build/tcnative.m4#L41-L45
> * https://github.com/apache/tomcat-native/blob/f6e1474c6b05e9cab0ad308647a3bde533c1cbce/native/src/jnilib.c#L77-L81
Thanks for pointing those out. There may be more. I'll fix them as we
spot them.
I don't see either of these as reasons to halt the 1.3.0 release. If
anyone has a different view, please comment on the vote thread.
>> The next 8.5.x and 9.0.x releases would then ship with Tomcat Native
>> 1.3.0 but minimum required/recommended Tomcat Native versions would not
>> change.
>
> I wouldn't bother with 8.5 and 1.3, I'd use 1.2.x until end of 8.5 and the put 1.2.x EOL.
I'm still leaning towards switching 8.5.x to 1.3.0 but if the consensus
is to stcik with the current 1.2.x release I'm fine with that. I'm
mainly trying to avoid another 1.2.x release on top of all the other
releases I am juggling at the moment.
> Overall sounds like a good plan. I will do also testing here on my side.
Tx.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: Moving to Tomcat Native 1.3.x
Posted by Michael Osipov <mi...@apache.org>.
On 2024/02/04 19:54:25 Mark Thomas wrote:
> Hi all,
>
> AS you have probably noticed I am working on another round of Tomcat
> Native releases.
>
> We are overdue on switching to 1.3.x so I would like to propose the
> following with this release round:
>
> - create a new 1.3.x branch from the current 1.2.x HEAD
> - update minimum OpenSSL to 1.1.1
> - update minimum APR to 1.6.3
> - remove code supporting OpenSSL < 1.1.1
Good, you have basically picked up https://bz.apache.org/bugzilla/show_bug.cgi?id=67683.
You have missed at least two spots:
* https://github.com/apache/tomcat-native/blob/f6e1474c6b05e9cab0ad308647a3bde533c1cbce/native/build/tcnative.m4#L41-L45
* https://github.com/apache/tomcat-native/blob/f6e1474c6b05e9cab0ad308647a3bde533c1cbce/native/src/jnilib.c#L77-L81
> The next 8.5.x and 9.0.x releases would then ship with Tomcat Native
> 1.3.0 but minimum required/recommended Tomcat Native versions would not
> change.
I wouldn't bother with 8.5 and 1.3, I'd use 1.2.x until end of 8.5 and the put 1.2.x EOL.
Overall sounds like a good plan. I will do also testing here on my side.
M
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: Moving to Tomcat Native 1.3.x
Posted by Michael Osipov <mi...@apache.org>.
On 2024/02/07 16:05:17 Michael Osipov wrote:
> On 2024/02/04 19:54:25 Mark Thomas wrote:
> > Hi all,
> >
> > AS you have probably noticed I am working on another round of Tomcat
> > Native releases.
> >
> > We are overdue on switching to 1.3.x so I would like to propose the
> > following with this release round:
> >
> > - create a new 1.3.x branch from the current 1.2.x HEAD
> > - update minimum OpenSSL to 1.1.1
> > - update minimum APR to 1.6.3
> > - remove code supporting OpenSSL < 1.1.1
> >
> > The next 8.5.x and 9.0.x releases would then ship with Tomcat Native
> > 1.3.0 but minimum required/recommended Tomcat Native versions would not
> > change.
>
> I have just tested Tomcat 9.0.x from Git repo against:
> FreeBSD 13-STABLE:
> OpenSSL 1.1.1w-freebsd 11 Sep 2023
> Tomcat Native library [1.3.1-dev] using APR version [1.7.3]
>
>
> HP-UX 11.31:
> OpenSSL 1.1.1w 11 Sep 2023
> Tomcat Native library [1.3.1-dev] using APR version [1.7.4]
>
> I will try with OpenSSL 3.0.x soon. It is very unfortunate that 9.0.x requires Java 17 to build, it is not available on HP-UX and will never be by HPE. I had to downgrade BND to 6.4.0 to make it run. I still consider this a wrong move for at least Tomcat 9.0.x, Java 11 should have stayed the minimum.
Both setups do also work with OpenSSL 3.0.13 30 Jan 2024
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: Moving to Tomcat Native 1.3.x
Posted by Christopher Schultz <ch...@christopherschultz.net>.
Michael,
On 2/7/24 14:14, Michael Osipov wrote:
> On 2024/02/07 18:19:24 Christopher Schultz wrote:
>> Michael,
>>
>> On 2/7/24 11:05, Michael Osipov wrote:
>>> On 2024/02/04 19:54:25 Mark Thomas wrote:
>>>> Hi all,
>>>>
>>>> AS you have probably noticed I am working on another round of Tomcat
>>>> Native releases.
>>>>
>>>> We are overdue on switching to 1.3.x so I would like to propose the
>>>> following with this release round:
>>>>
>>>> - create a new 1.3.x branch from the current 1.2.x HEAD
>>>> - update minimum OpenSSL to 1.1.1
>>>> - update minimum APR to 1.6.3
>>>> - remove code supporting OpenSSL < 1.1.1
>>>>
>>>> The next 8.5.x and 9.0.x releases would then ship with Tomcat Native
>>>> 1.3.0 but minimum required/recommended Tomcat Native versions would not
>>>> change.
>>>
>>> I have just tested Tomcat 9.0.x from Git repo against:
>>> FreeBSD 13-STABLE:
>>> OpenSSL 1.1.1w-freebsd 11 Sep 2023
>>> Tomcat Native library [1.3.1-dev] using APR version [1.7.3]
>>>
>>>
>>> HP-UX 11.31:
>>> OpenSSL 1.1.1w 11 Sep 2023
>>> Tomcat Native library [1.3.1-dev] using APR version [1.7.4]
>>>
>>> I will try with OpenSSL 3.0.x soon. It is very unfortunate that 9.0.x requires Java 17 to build, it is not available on HP-UX and will never be by HPE. I had to downgrade BND to 6.4.0 to make it run. I still consider this a wrong move for at least Tomcat 9.0.x, Java 11 should have stayed the minimum.
>>
>> I think it's actually possible to build with Java 11, but the release
>> builds require Java 17 for .... #reasons.
>>
>> Try just hacking the build files to allow Java 11 and see if you can build.
>
> It does work:
> diff --git a/build.properties.default b/build.properties.default
> index 2ec1dbfb16..82aec7debb 100644
> --- a/build.properties.default
> +++ b/build.properties.default
> @@ -307 +307 @@ spotbugs.loc=${base-maven.loc}/com/github/spotbugs/spotbugs/${spotbugs.version}/
> -bnd.version=7.0.0
> +bnd.version=6.4.0
> diff --git a/build.xml b/build.xml
> index 94e80620e2..83852a889f 100644
> --- a/build.xml
> +++ b/build.xml
> @@ -110 +110 @@
> - <property name="build.java.version" value="17"/>
> + <property name="build.java.version" value="11"/>
I will do some thinking about maybe only enforcing Java 17 for
release-builds and not "normal" builds.
-chris
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: Moving to Tomcat Native 1.3.x
Posted by Michael Osipov <mi...@apache.org>.
On 2024/02/07 18:19:24 Christopher Schultz wrote:
> Michael,
>
> On 2/7/24 11:05, Michael Osipov wrote:
> > On 2024/02/04 19:54:25 Mark Thomas wrote:
> >> Hi all,
> >>
> >> AS you have probably noticed I am working on another round of Tomcat
> >> Native releases.
> >>
> >> We are overdue on switching to 1.3.x so I would like to propose the
> >> following with this release round:
> >>
> >> - create a new 1.3.x branch from the current 1.2.x HEAD
> >> - update minimum OpenSSL to 1.1.1
> >> - update minimum APR to 1.6.3
> >> - remove code supporting OpenSSL < 1.1.1
> >>
> >> The next 8.5.x and 9.0.x releases would then ship with Tomcat Native
> >> 1.3.0 but minimum required/recommended Tomcat Native versions would not
> >> change.
> >
> > I have just tested Tomcat 9.0.x from Git repo against:
> > FreeBSD 13-STABLE:
> > OpenSSL 1.1.1w-freebsd 11 Sep 2023
> > Tomcat Native library [1.3.1-dev] using APR version [1.7.3]
> >
> >
> > HP-UX 11.31:
> > OpenSSL 1.1.1w 11 Sep 2023
> > Tomcat Native library [1.3.1-dev] using APR version [1.7.4]
> >
> > I will try with OpenSSL 3.0.x soon. It is very unfortunate that 9.0.x requires Java 17 to build, it is not available on HP-UX and will never be by HPE. I had to downgrade BND to 6.4.0 to make it run. I still consider this a wrong move for at least Tomcat 9.0.x, Java 11 should have stayed the minimum.
>
> I think it's actually possible to build with Java 11, but the release
> builds require Java 17 for .... #reasons.
>
> Try just hacking the build files to allow Java 11 and see if you can build.
It does work:
diff --git a/build.properties.default b/build.properties.default
index 2ec1dbfb16..82aec7debb 100644
--- a/build.properties.default
+++ b/build.properties.default
@@ -307 +307 @@ spotbugs.loc=${base-maven.loc}/com/github/spotbugs/spotbugs/${spotbugs.version}/
-bnd.version=7.0.0
+bnd.version=6.4.0
diff --git a/build.xml b/build.xml
index 94e80620e2..83852a889f 100644
--- a/build.xml
+++ b/build.xml
@@ -110 +110 @@
- <property name="build.java.version" value="17"/>
+ <property name="build.java.version" value="11"/>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: Moving to Tomcat Native 1.3.x
Posted by Christopher Schultz <ch...@christopherschultz.net>.
Michael,
On 2/7/24 11:05, Michael Osipov wrote:
> On 2024/02/04 19:54:25 Mark Thomas wrote:
>> Hi all,
>>
>> AS you have probably noticed I am working on another round of Tomcat
>> Native releases.
>>
>> We are overdue on switching to 1.3.x so I would like to propose the
>> following with this release round:
>>
>> - create a new 1.3.x branch from the current 1.2.x HEAD
>> - update minimum OpenSSL to 1.1.1
>> - update minimum APR to 1.6.3
>> - remove code supporting OpenSSL < 1.1.1
>>
>> The next 8.5.x and 9.0.x releases would then ship with Tomcat Native
>> 1.3.0 but minimum required/recommended Tomcat Native versions would not
>> change.
>
> I have just tested Tomcat 9.0.x from Git repo against:
> FreeBSD 13-STABLE:
> OpenSSL 1.1.1w-freebsd 11 Sep 2023
> Tomcat Native library [1.3.1-dev] using APR version [1.7.3]
>
>
> HP-UX 11.31:
> OpenSSL 1.1.1w 11 Sep 2023
> Tomcat Native library [1.3.1-dev] using APR version [1.7.4]
>
> I will try with OpenSSL 3.0.x soon. It is very unfortunate that 9.0.x requires Java 17 to build, it is not available on HP-UX and will never be by HPE. I had to downgrade BND to 6.4.0 to make it run. I still consider this a wrong move for at least Tomcat 9.0.x, Java 11 should have stayed the minimum.
I think it's actually possible to build with Java 11, but the release
builds require Java 17 for .... #reasons.
Try just hacking the build files to allow Java 11 and see if you can build.
-chris
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: Moving to Tomcat Native 1.3.x
Posted by Michael Osipov <mi...@apache.org>.
On 2024/02/04 19:54:25 Mark Thomas wrote:
> Hi all,
>
> AS you have probably noticed I am working on another round of Tomcat
> Native releases.
>
> We are overdue on switching to 1.3.x so I would like to propose the
> following with this release round:
>
> - create a new 1.3.x branch from the current 1.2.x HEAD
> - update minimum OpenSSL to 1.1.1
> - update minimum APR to 1.6.3
> - remove code supporting OpenSSL < 1.1.1
>
> The next 8.5.x and 9.0.x releases would then ship with Tomcat Native
> 1.3.0 but minimum required/recommended Tomcat Native versions would not
> change.
I have just tested Tomcat 9.0.x from Git repo against:
FreeBSD 13-STABLE:
OpenSSL 1.1.1w-freebsd 11 Sep 2023
Tomcat Native library [1.3.1-dev] using APR version [1.7.3]
HP-UX 11.31:
OpenSSL 1.1.1w 11 Sep 2023
Tomcat Native library [1.3.1-dev] using APR version [1.7.4]
I will try with OpenSSL 3.0.x soon. It is very unfortunate that 9.0.x requires Java 17 to build, it is not available on HP-UX and will never be by HPE. I had to downgrade BND to 6.4.0 to make it run. I still consider this a wrong move for at least Tomcat 9.0.x, Java 11 should have stayed the minimum.
Michael
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org