You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@phoenix.apache.org by "Sergey Soldatov (JIRA)" <ji...@apache.org> on 2017/11/08 19:04:00 UTC

[jira] [Comment Edited] (PHOENIX-4357) IndexRegionSplitPolicy extends the private-audience class IncreasingToUpperBoundRegionSplitPolicy

    [ https://issues.apache.org/jira/browse/PHOENIX-4357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16244552#comment-16244552 ] 

Sergey Soldatov edited comment on PHOENIX-4357 at 11/8/17 7:03 PM:
-------------------------------------------------------------------

The main con that I see in copying code is the maintenance (someone should keep an eye on the changes in HBase code and reflect them in Phoenix). It would be far better is to set visibility of IncreasingToUpperBoundRegionSplitPolicy to {noformat} @InterfaceAudience.LimitedPrivate({HBaseInterfaceAudience.PHOENIX}). {noformat} Also we need to keep in mind that in HBase 2.0 the default split policy has been changed to SteppingSplitPolicy and we need to adopt it as well.   


was (Author: sergey.soldatov):
The main con that I see in copying code is the maintenance (someone should keep an eye on the changes in HBase code and reflect them in Phoenix). It would be far better is to set visibility of IncreasingToUpperBoundRegionSplitPolicy to @InterfaceAudience.LimitedPrivate({HBaseInterfaceAudience.PHOENIX}).  Also we need to keep in mind that in HBase 2.0 the default split policy has been changed to SteppingSplitPolicy and we need to adopt it as well.   

> IndexRegionSplitPolicy extends the private-audience class IncreasingToUpperBoundRegionSplitPolicy
> -------------------------------------------------------------------------------------------------
>
>                 Key: PHOENIX-4357
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4357
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: Josh Elser
>
> IndexRegionSplitPolicy extends IncreasingToUpperBoundRegionSplitPolicy which is subject to change (marked as Private by HBase). We should come up with a solution that doesn't break Phoenix is HBase happens to change the implementation.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)