You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2021/03/16 16:41:00 UTC

[GitHub] [hbase] wchevreuil opened a new pull request #3055: HBASE-25656 Backport to branch-2.2: [HBASE-25548 Optionally allow sna…

wchevreuil opened a new pull request #3055:
URL: https://github.com/apache/hbase/pull/3055


   …pshots to preserve cluster's max filesize config by setting it into table descriptor]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hbase] Apache-HBase commented on pull request #3055: HBASE-25656 Backport to branch-2.2: [HBASE-25548 Optionally allow sna…

Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3055:
URL: https://github.com/apache/hbase/pull/3055#issuecomment-801276057


   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   0m 34s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files found.  |
   | +0 :ok: |  prototool  |   0m  0s |  prototool was not available.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  Patch does not have any anti-patterns.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  The patch appears to include 2 new or modified test files.  |
   ||| _ branch-2.2 Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 17s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   3m 13s |  branch-2.2 passed  |
   | +1 :green_heart: |  compile  |   1m 56s |  branch-2.2 passed  |
   | +1 :green_heart: |  checkstyle  |   4m 32s |  branch-2.2 passed  |
   | +0 :ok: |  refguide  |  16m 17s |  branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.  |
   | +1 :green_heart: |  shadedjars  |   4m  0s |  branch has no errors when building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   3m 29s |  branch-2.2 passed  |
   | +0 :ok: |  spotbugs  |   2m 48s |  Used deprecated FindBugs config; considering switching to SpotBugs.  |
   | +1 :green_heart: |  findbugs  |  15m 21s |  branch-2.2 passed  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 15s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   2m 54s |  the patch passed  |
   | +1 :green_heart: |  compile  |   1m 55s |  the patch passed  |
   | +1 :green_heart: |  cc  |   1m 55s |  the patch passed  |
   | +1 :green_heart: |  javac  |   1m 55s |  the patch passed  |
   | -1 :x: |  checkstyle  |   0m 43s |  hbase-client: The patch generated 1 new + 270 unchanged - 0 fixed = 271 total (was 270)  |
   | -1 :x: |  checkstyle  |   2m  8s |  root: The patch generated 1 new + 298 unchanged - 0 fixed = 299 total (was 298)  |
   | -1 :x: |  rubocop  |   0m 11s |  The patch generated 3 new + 370 unchanged - 1 fixed = 373 total (was 371)  |
   | -1 :x: |  whitespace  |   0m  0s |  The patch has 25 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply  |
   | +0 :ok: |  refguide  |   5m  9s |  patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.  |
   | +1 :green_heart: |  shadedjars  |   4m  4s |  patch has no errors when building our shaded downstream artifacts.  |
   | +1 :green_heart: |  hadoopcheck  |  27m 29s |  Patch does not cause any errors with Hadoop 2.8.5 2.9.2 2.10.0 or 3.1.2 3.2.1.  |
   | +1 :green_heart: |  hbaseprotoc  |   5m 27s |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   3m 48s |  the patch passed  |
   | +1 :green_heart: |  findbugs  |  16m  7s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  | 136m 51s |  root in the patch passed.  |
   | +1 :green_heart: |  asflicense  |   2m 37s |  The patch does not generate ASF License warnings.  |
   |  |   | 269m 14s |   |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3055/2/artifact/out/Dockerfile |
   | GITHUB PR | https://github.com/apache/hbase/pull/3055 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool rubocop refguide |
   | uname | Linux 9cba0eb71fdb 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | /home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-3055/out/precommit/personality/provided.sh |
   | git revision | branch-2.2 / bf6fad3398 |
   | Default Java | Oracle Corporation-1.8.0_282-b08 |
   | refguide | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3055/2/artifact/out/branch-site/book.html |
   | checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3055/2/artifact/out/diff-checkstyle-hbase-client.txt |
   | checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3055/2/artifact/out/diff-checkstyle-root.txt |
   | rubocop | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3055/2/artifact/out/diff-patch-rubocop.txt |
   | whitespace | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3055/2/artifact/out/whitespace-eol.txt |
   | refguide | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3055/2/artifact/out/patch-site/book.html |
   |  Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3055/2/testReport/ |
   | Max. process+thread count | 3829 (vs. ulimit of 12500) |
   | modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-shell . U: . |
   | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3055/2/console |
   | versions | git=2.20.1 maven=3.6.3 findbugs=3.1.11 rubocop=0.81.0 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hbase] wchevreuil commented on pull request #3055: HBASE-25656 Backport to branch-2.2: [HBASE-25548 Optionally allow sna…

Posted by GitBox <gi...@apache.org>.
wchevreuil commented on pull request #3055:
URL: https://github.com/apache/hbase/pull/3055#issuecomment-801135308


   > LGTM. Its safe to backport because we provide defaults for the API added?
   
   Correct, the parameter is optional, if not specified, we'll not apply it.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hbase] Apache-HBase commented on pull request #3055: HBASE-25656 Backport to branch-2.2: [HBASE-25548 Optionally allow sna…

Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3055:
URL: https://github.com/apache/hbase/pull/3055#issuecomment-800613182


   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   2m 34s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  1s |  No case conflicting files found.  |
   | +0 :ok: |  prototool  |   0m  0s |  prototool was not available.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  Patch does not have any anti-patterns.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  The patch appears to include 2 new or modified test files.  |
   ||| _ branch-2.2 Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 19s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   3m 23s |  branch-2.2 passed  |
   | +1 :green_heart: |  compile  |   1m 57s |  branch-2.2 passed  |
   | +1 :green_heart: |  checkstyle  |   4m 38s |  branch-2.2 passed  |
   | +0 :ok: |  refguide  |  16m 14s |  branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.  |
   | +1 :green_heart: |  shadedjars  |   4m 17s |  branch has no errors when building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   3m 46s |  branch-2.2 passed  |
   | +0 :ok: |  spotbugs  |   3m  3s |  Used deprecated FindBugs config; considering switching to SpotBugs.  |
   | +1 :green_heart: |  findbugs  |  17m 12s |  branch-2.2 passed  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 16s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   3m  3s |  the patch passed  |
   | +1 :green_heart: |  compile  |   2m  7s |  the patch passed  |
   | +1 :green_heart: |  cc  |   2m  7s |  the patch passed  |
   | +1 :green_heart: |  javac  |   2m  7s |  the patch passed  |
   | -1 :x: |  checkstyle  |   0m 40s |  hbase-client: The patch generated 3 new + 270 unchanged - 0 fixed = 273 total (was 270)  |
   | -1 :x: |  checkstyle  |   2m 17s |  root: The patch generated 3 new + 298 unchanged - 0 fixed = 301 total (was 298)  |
   | -1 :x: |  rubocop  |   0m 10s |  The patch generated 3 new + 370 unchanged - 1 fixed = 373 total (was 371)  |
   | -1 :x: |  whitespace  |   0m  0s |  The patch has 25 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply  |
   | +0 :ok: |  refguide  |   5m 22s |  patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.  |
   | +1 :green_heart: |  shadedjars  |   3m 55s |  patch has no errors when building our shaded downstream artifacts.  |
   | +1 :green_heart: |  hadoopcheck  |  27m 38s |  Patch does not cause any errors with Hadoop 2.8.5 2.9.2 2.10.0 or 3.1.2 3.2.1.  |
   | +1 :green_heart: |  hbaseprotoc  |   5m 28s |  the patch passed  |
   | -1 :x: |  javadoc  |   0m 25s |  hbase-client generated 1 new + 2 unchanged - 0 fixed = 3 total (was 2)  |
   | -1 :x: |  javadoc  |   2m 18s |  root generated 1 new + 6 unchanged - 0 fixed = 7 total (was 6)  |
   | -1 :x: |  findbugs  |   1m 28s |  hbase-client generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)  |
   | -1 :x: |  findbugs  |   9m 16s |  root generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  | 138m 52s |  root in the patch passed.  |
   | +1 :green_heart: |  asflicense  |   2m 40s |  The patch does not generate ASF License warnings.  |
   |  |   | 277m 25s |   |
   
   
   | Reason | Tests |
   |-------:|:------|
   | FindBugs | module:hbase-client |
   |  |  Useless object stored in variable snapshotProps of method org.apache.hadoop.hbase.shaded.protobuf.ProtobufUtil.createSnapshotDesc(SnapshotProtos$SnapshotDescription)  At ProtobufUtil.java:snapshotProps of method org.apache.hadoop.hbase.shaded.protobuf.ProtobufUtil.createSnapshotDesc(SnapshotProtos$SnapshotDescription)  At ProtobufUtil.java:[line 2946] |
   | FindBugs | module:root |
   |  |  Useless object stored in variable snapshotProps of method org.apache.hadoop.hbase.shaded.protobuf.ProtobufUtil.createSnapshotDesc(SnapshotProtos$SnapshotDescription)  At ProtobufUtil.java:snapshotProps of method org.apache.hadoop.hbase.shaded.protobuf.ProtobufUtil.createSnapshotDesc(SnapshotProtos$SnapshotDescription)  At ProtobufUtil.java:[line 2946] |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3055/1/artifact/out/Dockerfile |
   | GITHUB PR | https://github.com/apache/hbase/pull/3055 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool rubocop refguide |
   | uname | Linux 2a972c14b5e6 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | /home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-3055/out/precommit/personality/provided.sh |
   | git revision | branch-2.2 / bf6fad3398 |
   | Default Java | Oracle Corporation-1.8.0_282-b08 |
   | refguide | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3055/1/artifact/out/branch-site/book.html |
   | checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3055/1/artifact/out/diff-checkstyle-hbase-client.txt |
   | checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3055/1/artifact/out/diff-checkstyle-root.txt |
   | rubocop | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3055/1/artifact/out/diff-patch-rubocop.txt |
   | whitespace | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3055/1/artifact/out/whitespace-eol.txt |
   | refguide | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3055/1/artifact/out/patch-site/book.html |
   | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3055/1/artifact/out/diff-javadoc-javadoc-hbase-client.txt |
   | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3055/1/artifact/out/diff-javadoc-javadoc-root.txt |
   | findbugs | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3055/1/artifact/out/new-findbugs-hbase-client.html |
   | findbugs | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3055/1/artifact/out/new-findbugs-root.html |
   |  Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3055/1/testReport/ |
   | Max. process+thread count | 3101 (vs. ulimit of 12500) |
   | modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-shell . U: . |
   | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3055/1/console |
   | versions | git=2.20.1 maven=3.6.3 findbugs=3.1.11 rubocop=0.81.0 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hbase] petersomogyi commented on a change in pull request #3055: HBASE-25656 Backport to branch-2.2: [HBASE-25548 Optionally allow sna…

Posted by GitBox <gi...@apache.org>.
petersomogyi commented on a change in pull request #3055:
URL: https://github.com/apache/hbase/pull/3055#discussion_r596013597



##########
File path: src/main/asciidoc/_chapters/ops_mgt.adoc
##########
@@ -3191,40 +3208,38 @@ full implications and have a sufficient background in managing HBase clusters.
 It was developed by Yahoo! and they run it at scale on their large grid cluster.
 See link:http://www.slideshare.net/HBaseCon/keynote-apache-hbase-at-yahoo-scale[HBase at Yahoo! Scale].
 
-RSGroups are defined and managed with shell commands. The shell drives a
-Coprocessor Endpoint whose API is marked private given this is an evolving
-feature; the Coprocessor API is not for public consumption.
+RSGroups can be defined and managed with both admin methods and shell commands.

Review comment:
       Are these RSGroup related doc changes made on purpose or the cherry-pick introduced them?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hbase] wchevreuil merged pull request #3055: HBASE-25656 Backport to branch-2.2: [HBASE-25548 Optionally allow sna…

Posted by GitBox <gi...@apache.org>.
wchevreuil merged pull request #3055:
URL: https://github.com/apache/hbase/pull/3055


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hbase] Apache-HBase commented on pull request #3055: HBASE-25656 Backport to branch-2.2: [HBASE-25548 Optionally allow sna…

Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3055:
URL: https://github.com/apache/hbase/pull/3055#issuecomment-801473808


   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   0m 33s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files found.  |
   | +0 :ok: |  prototool  |   0m  0s |  prototool was not available.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  Patch does not have any anti-patterns.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  The patch appears to include 2 new or modified test files.  |
   ||| _ branch-2.2 Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 17s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   3m 11s |  branch-2.2 passed  |
   | +1 :green_heart: |  compile  |   1m 56s |  branch-2.2 passed  |
   | +1 :green_heart: |  checkstyle  |   4m 26s |  branch-2.2 passed  |
   | +0 :ok: |  refguide  |  16m 19s |  branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.  |
   | +1 :green_heart: |  shadedjars  |   4m  2s |  branch has no errors when building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   3m 31s |  branch-2.2 passed  |
   | +0 :ok: |  spotbugs  |   2m 38s |  Used deprecated FindBugs config; considering switching to SpotBugs.  |
   | +1 :green_heart: |  findbugs  |  15m  6s |  branch-2.2 passed  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 16s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   2m 52s |  the patch passed  |
   | +1 :green_heart: |  compile  |   1m 57s |  the patch passed  |
   | +1 :green_heart: |  cc  |   1m 57s |  the patch passed  |
   | +1 :green_heart: |  javac  |   1m 57s |  the patch passed  |
   | -1 :x: |  checkstyle  |   0m 44s |  hbase-client: The patch generated 1 new + 270 unchanged - 0 fixed = 271 total (was 270)  |
   | -1 :x: |  checkstyle  |   2m 10s |  root: The patch generated 1 new + 298 unchanged - 0 fixed = 299 total (was 298)  |
   | -1 :x: |  rubocop  |   0m 10s |  The patch generated 3 new + 370 unchanged - 1 fixed = 373 total (was 371)  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace issues.  |
   | +0 :ok: |  refguide  |   5m 17s |  patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.  |
   | +1 :green_heart: |  shadedjars  |   4m  0s |  patch has no errors when building our shaded downstream artifacts.  |
   | +1 :green_heart: |  hadoopcheck  |  25m 42s |  Patch does not cause any errors with Hadoop 2.8.5 2.9.2 2.10.0 or 3.1.2 3.2.1.  |
   | +1 :green_heart: |  hbaseprotoc  |   5m 20s |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   3m 42s |  the patch passed  |
   | +1 :green_heart: |  findbugs  |  18m 13s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  | 137m 53s |  root in the patch passed.  |
   | +1 :green_heart: |  asflicense  |   2m 34s |  The patch does not generate ASF License warnings.  |
   |  |   | 269m  9s |   |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3055/3/artifact/out/Dockerfile |
   | GITHUB PR | https://github.com/apache/hbase/pull/3055 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool rubocop refguide |
   | uname | Linux e39fdb1ecec1 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | /home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-3055/out/precommit/personality/provided.sh |
   | git revision | branch-2.2 / bf6fad3398 |
   | Default Java | Oracle Corporation-1.8.0_282-b08 |
   | refguide | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3055/3/artifact/out/branch-site/book.html |
   | checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3055/3/artifact/out/diff-checkstyle-hbase-client.txt |
   | checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3055/3/artifact/out/diff-checkstyle-root.txt |
   | rubocop | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3055/3/artifact/out/diff-patch-rubocop.txt |
   | refguide | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3055/3/artifact/out/patch-site/book.html |
   |  Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3055/3/testReport/ |
   | Max. process+thread count | 3938 (vs. ulimit of 12500) |
   | modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-shell . U: . |
   | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3055/3/console |
   | versions | git=2.20.1 maven=3.6.3 findbugs=3.1.11 rubocop=0.81.0 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hbase] wchevreuil commented on a change in pull request #3055: HBASE-25656 Backport to branch-2.2: [HBASE-25548 Optionally allow sna…

Posted by GitBox <gi...@apache.org>.
wchevreuil commented on a change in pull request #3055:
URL: https://github.com/apache/hbase/pull/3055#discussion_r596063919



##########
File path: src/main/asciidoc/_chapters/ops_mgt.adoc
##########
@@ -3191,40 +3208,38 @@ full implications and have a sufficient background in managing HBase clusters.
 It was developed by Yahoo! and they run it at scale on their large grid cluster.
 See link:http://www.slideshare.net/HBaseCon/keynote-apache-hbase-at-yahoo-scale[HBase at Yahoo! Scale].
 
-RSGroups are defined and managed with shell commands. The shell drives a
-Coprocessor Endpoint whose API is marked private given this is an evolving
-feature; the Coprocessor API is not for public consumption.
+RSGroups can be defined and managed with both admin methods and shell commands.

Review comment:
       That was introduced automatically by the cherry-pick. Need to revert it.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org