You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "lyne7-sc (via GitHub)" <gi...@apache.org> on 2026/09/17 15:44:38 UTC
[PR] perf: Prune matched right rows in nested loop semi and anti joins [datafusion]
lyne7-sc opened a new pull request, #25413:
URL: https://github.com/apache/datafusion/pull/25413
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
- Closes #.
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
Please explain the problem you are trying to solve in terms of the user-visible
behavior, rather than the implementation.
For example, "The code in `foo.rs` doesn't handle nulls" is a symptom of the
implementation. "COUNT(DISTINCT) returns wrong results when the column contains
nulls" is the user-visible problem.
-->
For `RightSemi` and `RightAnti` nested loop joins, each right row only needs one match to determine whether it belongs in the result. Currently, matched right rows continue participating in comparisons with subsequent left rows.
Skipping these comparisons can significantly reduce execution time when matches are found early.
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here, but it is sometimes worth providing a summary of the individual changes in this PR.
-->
- Add `RightExistenceProbe` to track matches and right-side candidates.
- Compact the right-side filter columns when at least half the candidates have matched and more left rows remain.
- Stop probing the current right batch when all its rows have matched.
- Preserve matches in original right-row coordinates for output and spill handling.
## What is the testing strategy for this PR?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
Briefly describe how this PR is tested, and point to the specific tests you added. For example: 'This new feature is covered by the `sqllogictest` cases added in `foo.slt`'.
If this PR does not add tests, explain why. For example, if the change is already covered by existing tests, please mention it.
You should also check the `codecov` bot reply on this PR to confirm the changed code is exercised.
-->
- Add unit tests for match tracking and candidate compaction.
- Add SQL coverage in `nested_loop_join_existence.slt` for RightSemi/RightAnti joins, including NULLs, repeated matches, and multiple left rows per probe.
- Extend `nested_loop_join_spill.slt` to cover RightSemi/RightAnti joins across spilled left chunks.
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
If there are any breaking changes to public APIs, please add the `api change` label.
-->
No. This is an internal performance optimization.
## Benchmark results
| Case | Scenario | main | This PR | Time change |
|---|---|---:|---:|---:|
| Q15 | Right Semi, early matches | 307.659 | 0.365 | -99.88% |
| Q16 | Right Anti, early matches | 306.225 | 0.338 | -99.89% |
| Q18 | Right Semi, no matches | 7.964 | 7.728 | -2.95% |
| Q19 | Right Anti, no matches | 8.100 | 7.770 | -4.07% |
| Q20 | Right Semi, staged compaction | 56.082 | 7.182 | -87.19% |
| Q21 | Right Anti, staged compaction | 56.057 | 7.115 | -87.31% |
| Q22 | Right Semi, repeated 40% matches (4,096 left × 8,192 right) | 12.185 | 12.410 | +1.84% |
| Q23 | Right Anti, final-left-row matches with wide Utf8 | 0.305125 | 0.309042 | +1.28% |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] perf: Prune matched right rows in nested loop semi and anti joins [datafusion]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #25413:
URL: https://github.com/apache/datafusion/pull/25413#issuecomment-5717553281
## [Codecov](https://app.codecov.io/gh/apache/datafusion/pull/25413?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `89.74359%` with `12 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 82.33%. Comparing base ([`606ae0f`](https://app.codecov.io/gh/apache/datafusion/commit/606ae0f697380a5bb903909f7ee3c731abbc6b79?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b9fb069`](https://app.codecov.io/gh/apache/datafusion/commit/b9fb06973b8e5d2aa510ca517091b7b9fa3500bb?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 31 commits behind head on main.
| [Files with missing lines](https://app.codecov.io/gh/apache/datafusion/pull/25413?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...fusion/physical-plan/src/joins/nested\_loop\_join.rs](https://app.codecov.io/gh/apache/datafusion/pull/25413?src=pr&el=tree&filepath=datafusion%2Fphysical-plan%2Fsrc%2Fjoins%2Fnested_loop_join.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZGF0YWZ1c2lvbi9waHlzaWNhbC1wbGFuL3NyYy9qb2lucy9uZXN0ZWRfbG9vcF9qb2luLnJz) | 89.74% | [8 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/datafusion/pull/25413?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #25413 +/- ##
==========================================
+ Coverage 81.94% 82.33% +0.38%
==========================================
Files 1135 1137 +2
Lines 428278 432064 +3786
Branches 428278 432064 +3786
==========================================
+ Hits 350952 355737 +4785
+ Misses 56369 54822 -1547
- Partials 20957 21505 +548
```
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/datafusion/pull/25413?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] perf: Prune matched right rows in nested loop semi and anti joins [datafusion]
Posted by "kosiew (via GitHub)" <gi...@apache.org>.
kosiew commented on PR #25413:
URL: https://github.com/apache/datafusion/pull/25413#issuecomment-6015202293
[nlj benchmark](https://github.com/apache/datafusion/pull/26080#issuecomment-6014326409) (excerpt)
```
Benchmark nlj.json
--------------------
┏━━━━━━━━━━━┳━━━━━━━━━━━━┳━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━┓
┃ Query ┃ HEAD ┃ bench-25413 ┃ Change ┃
┡━━━━━━━━━━━╇━━━━━━━━━━━━╇━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━┩
│ QQuery 15 │ 110.09 ms │ 0.58 ms │ +188.66x faster │
│ QQuery 16 │ 110.38 ms │ 0.59 ms │ +185.80x faster │
└───────────┴────────────┴─────────────┴─────────────────┘
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] perf: Prune matched right rows in nested loop semi and anti joins [datafusion]
Posted by "kosiew (via GitHub)" <gi...@apache.org>.
kosiew commented on PR #25413:
URL: https://github.com/apache/datafusion/pull/25413#issuecomment-6076748163
🚀
@lyne7-sc
Thank you for your contribution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] perf: Prune matched right rows in nested loop semi and anti joins [datafusion]
Posted by "lyne7-sc (via GitHub)" <gi...@apache.org>.
lyne7-sc commented on PR #25413:
URL: https://github.com/apache/datafusion/pull/25413#issuecomment-6061900015
Thanks @kosiew for the review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] perf: Prune matched right rows in nested loop semi and anti joins [datafusion]
Posted by "kosiew (via GitHub)" <gi...@apache.org>.
kosiew merged PR #25413:
URL: https://github.com/apache/datafusion/pull/25413
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org